You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2020/11/25 04:24:09 UTC
[zeppelin] branch branch-0.9 updated: [ZEPPELIN-5140]Close
RemoteInterpreter when RemoteInterpreterServer already timeout.
This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/branch-0.9 by this push:
new 2116a8d [ZEPPELIN-5140]Close RemoteInterpreter when RemoteInterpreterServer already timeout.
2116a8d is described below
commit 2116a8d6bc4dfefb04a28a816416caa0e75d2cea
Author: zhengsl <zh...@getui.com>
AuthorDate: Sat Nov 21 16:32:00 2020 +0800
[ZEPPELIN-5140]Close RemoteInterpreter when RemoteInterpreterServer already timeout.
### What is this PR for?
This PR is to fix ZEPPELIN-5135.
Close RemoteInterpreter when RemoteInterpreterServer already timeout.
Otherwise the ProgressBar will be missing when rerun after the RemoteInterpreterServer timeout and old RemoteInterpreterGroup will always alive after GC.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-5140
### How should this be tested?
* First, run a paragraph using spark interpreter
* Then, wait the TimeoutLifecycleManager to expire
* Rerun the above paragraph, and the progress bar is missing.
After the bug fixed, the above issue is solved
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: zhengsl <zh...@getui.com>
Closes #3978 from zhengslei/master and squashes the following commits:
3fdbd2676 [zhengsl] [ZEPPELIN-5140]Close RemoteInterpreter when RemoteInterpreterServer already timeout.
(cherry picked from commit 49f2346b34fa702fe3ead94febdd8dd5b07592c8)
Signed-off-by: Jeff Zhang <zj...@apache.org>
---
.../org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java
index f24e477..bdaf6c8 100644
--- a/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java
+++ b/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java
@@ -188,6 +188,10 @@ public class RemoteInterpreterEventServer implements RemoteInterpreterEventServi
intpGroupId);
return;
}
+ // Close RemoteInterpreter when RemoteInterpreterServer already timeout.
+ // Otherwise the ProgressBar will be missing when rerun after the RemoteInterpreterServer timeout
+ // and old RemoteInterpreterGroups will always alive after GC.
+ interpreterGroup.close();
interpreterSettingManager.removeInterpreterGroup(intpGroupId);
}