[GitHub] [cordova] raphinesse commented on issue #184: cordova create does not accept valid domain names containing dashes

[GitBox <gi...@apache.org>]

raphinesse commented on issue #184:
URL: https://github.com/apache/cordova/issues/184#issuecomment-647184803


   > So one way to fix this _situation_ is to improve valid-identifier to throw an Error or implement some mechanism to bubble the offending part, seeing how valid-identifier has not been updated in a few years Id say chances of pull requests being accepted are slim
   
   Actually, the `valid-identifier` package is maintained by Cordova's current PMC chair, @purplecabbage. So if there would be a quality contribution to improve it, I'm sure it would be considered.
   
   I don't think opening an issue in cordova-cli would help. I rather suggest you open a pull request on our docs to fix the lack of documentation regarding the constraints for app identifiers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org