You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2017/04/27 19:23:23 UTC
[GitHub] nifi-minifi-cpp pull request #84: MINIFI-274 Use external project with exist...
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/84
MINIFI-274 Use external project with existing source for jsoncpp to
MINIFI-274 Use external project with existing source for jsoncpp to avoid contamination of core project build.
This was done in a minimal fashion to solve the issue before delving too much into restructuring current format to make use of ExternalProjects for the remaining dependencies.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi-cpp minifi-274-jsoncpp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit cbcda83b551f6130a5c334dd4063ebb1e9422cca
Author: Aldrin Piri <al...@apache.org>
Date: 2017-04-27T18:26:48Z
MINIFI-274 Use external project with existing source for jsoncpp to
avoid contamination of core project build.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@brosander could you list your environment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@apiri Issues experience by @brosander appear to be solved with https://github.com/phrocker/nifi-minifi-cpp/tree/minifi-274-jsoncpp. The top two commits are the necessary commits. Feel free to squash them.
87e6b29abd688b980e7bbc512174ad9c17304742
6eb8f898b52aa10eea07d209402ea228bbf70723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@apiri I'll take a look, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
definitely better but I still seem to be getting a segfault on the s2s test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
```
TestSiteToSiteVerifySend
-------------------------------------------------------------------------------
/home/bryan/Github/nifi-minifi-cpp/libminifi/test/unit/Site2SiteTests.cpp:102
...............................................................................
/home/bryan/Github/nifi-minifi-cpp/libminifi/test/unit/Site2SiteTests.cpp:102: FAILED:
due to a fatal error condition:
SIGSEGV - Segmentation violation signal
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by kevdoran <gi...@git.apache.org>.
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
I was able to reproduce the same behavior using the steps @brosander provided in his comment. MacOS 10.12.4 and Docker CE v 10.03.1-ce-mac5 (16048), stable, b18e2a50cc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@brosander looks like some of the environment issues have been ironed out and things look good in Travis, OSX 10.11, & Ubuntu 17.04.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@brosander just noticed there was a merge conflict from one of the prior merges I performed. will fix up quickly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
The following docker image repros it for me:
https://github.com/brosander/minifi-cpp-tooling/tree/9e5b1031d1772ccbee3ec8844a3decf232185284/Dockerfiles/ubuntu/xenial/build
```
docker build -t minifi-cpp-xenial-build .
mkdir build
docker run -ti --rm -v "$(pwd)/build:/build" minifi-cpp-xenial-build 84
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp pull request #84: MINIFI-274 Use external project with exist...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@brosander Okay, rebased on latest master and have pushed to update. Thanks for scoping out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@brosander Scope out @phrocker's work and merged into my branch which should address the build issues as per MINIFI-283. Updated my branch/PR to include those changes. Let us know how things look for you in the current state.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
+1 merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
Ubuntu 16.04 64 bit (latest LTS release of Ubuntu) I'll craft a dockerfile for easier testing/validation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #84: MINIFI-274 Use external project with existing sou...
Posted by brosander <gi...@git.apache.org>.
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
+1 works for me on bare metal Ubuntu 16.04, OSx 10.12.4, in docker container on both platforms as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---