You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 21:37:00 UTC

[GitHub] [arrow] jduo commented on a diff in pull request #12747: ARROW-16064: [Java] [C++] [FlightRPC] Add missing column metadata for type name on FlightSQL

jduo commented on code in PR #12747:
URL: https://github.com/apache/arrow/pull/12747#discussion_r858047117


##########
cpp/src/arrow/flight/sql/column_metadata.h:
##########
@@ -78,6 +81,10 @@ class ColumnMetadata {
   /// \return The table name.
   arrow::Result<std::string> GetTableName() const;
 
+  /// \brief  Return the type name set in the KeyValueMetadata.

Review Comment:
   ```suggestion
     /// \brief  Return the data source-specific name for the data type of the column.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org