You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by isaias <gi...@git.apache.org> on 2014/08/20 02:32:18 UTC
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
GitHub user isaias opened a pull request:
https://github.com/apache/spark/pull/2048
[SPARK-2312] Logging Unhandled messages
Note about tests: The best way to write tests for Log is use the TestEventListener and EventFilter of Akka, but the current Actors aren't using default ActorLogging and the current configuration are outputting results to a file instead STDOUT.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/isaias/spark SPARK-2312
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2048
----
commit 1a5fc76c958f98af583be7cef50631ee3a451444
Author: Isaias Barroso <is...@gmail.com>
Date: 2014-08-20T00:22:19Z
[SPARK-2312] Logging Unhandled messages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52745114
Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52736175
Why don't we just change ActorLogReceive to log messages not defined in the partial function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by isaias <gi...@git.apache.org>.
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52745159
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by isaias <gi...@git.apache.org>.
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52742677
@rxin, the trait ActorLogReceive gets the concrete implementation through receiveWithLogging function overriding of implementing Actor and applying it, so I think that on trait I can't identify the unhandled message of concrete implementation. Maybe I'm missing something, but I'll review.
BR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52742926
You just need to change
```scala
override def isDefinedAt(o: Any): Boolean = _receiveWithLogging.isDefinedAt(o)
```
to
```scala
override def isDefinedAt(o: Any): Boolean = {
val handled = _receiveWithLogging.isDefinedAt(o)
if (!handled) {
log ...
}
handled
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by isaias <gi...@git.apache.org>.
Github user isaias commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52744357
@rxin Very nice, it works. Should be better to close this PR and send another just with the trait changes?
BR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by isaias <gi...@git.apache.org>.
Github user isaias closed the pull request at:
https://github.com/apache/spark/pull/2048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2312] Logging Unhandled messages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2048#issuecomment-52720190
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org