You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 16:00:15 UTC
[GitHub] [beam] robertwb opened a new pull request, #23092: Cross-langauge tests in github actions.
robertwb opened a new pull request, #23092:
URL: https://github.com/apache/beam/pull/23092
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23092:
URL: https://github.com/apache/beam/pull/23092#issuecomment-1241007304
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23092:
URL: https://github.com/apache/beam/pull/23092#discussion_r966223079
##########
sdks/typescript/test/io_test.ts:
##########
@@ -59,13 +59,17 @@ before(() => {
after(() => subprocessCache.stopAll());
+function xlang_it(name, fn) {
+ return (process.env.BEAM_SERVICE_OVERRIDES ? it : it.skip)(name + ' @xlang', fn);
+}
+
// These depends on fixes that will be released in 2.40.
// They can be run manually by setting an environment variable
-// expor tBEAM_SERVICE_OVERRIDES = '{python:*": "/path/to/dev/venv/bin/python"}'
+// export BEAM_SERVICE_OVERRIDES = '{python:*": "/path/to/dev/venv/bin/python"}'
// TODO: Automatically set up/depend on such a venv in dev environments and/or
// testing infra.
-xdescribe("IO Tests", function () {
- it("textio file test", async function () {
+describe("IO Tests", function () {
+ xit("textio file test", async function () {
Review Comment:
```suggestion
xlang_it("textio file test", async function () {
```
##########
.github/workflows/typescript_tests.yml:
##########
@@ -64,3 +64,38 @@ jobs:
- run: npm test
working-directory: ./sdks/typescript
# if: ${{ matrix.os != 'ubuntu-latest' }}
+
+ typescript_xlang_tests:
+ name: 'TypeScript xlang Tests'
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: Install node
+ uses: actions/setup-node@v3
+ with:
+ node-version: '16'
+ - name: Install python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Setup Beam Python
+ working-directory: ./sdks/python
+ run: |
+ pip install pip setuptools --upgrade
+ pip install -r build-requirements.txt
+ pip install 'pandas>=1.0,<1.5'
Review Comment:
Why do we end up needing a special pandas install?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #23092:
URL: https://github.com/apache/beam/pull/23092#discussion_r966251360
##########
.github/workflows/typescript_tests.yml:
##########
@@ -64,3 +64,38 @@ jobs:
- run: npm test
working-directory: ./sdks/typescript
# if: ${{ matrix.os != 'ubuntu-latest' }}
+
+ typescript_xlang_tests:
+ name: 'TypeScript xlang Tests'
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: Install node
+ uses: actions/setup-node@v3
+ with:
+ node-version: '16'
+ - name: Install python
+ uses: actions/setup-python@v4
+ with:
+ python-version: 3.8
+ - name: Setup Beam Python
+ working-directory: ./sdks/python
+ run: |
+ pip install pip setuptools --upgrade
+ pip install -r build-requirements.txt
+ pip install 'pandas>=1.0,<1.5'
Review Comment:
Pandas is an optional dependency for dataflow, but is used for the csv/json/parquet reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb merged pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
robertwb merged PR #23092:
URL: https://github.com/apache/beam/pull/23092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23092:
URL: https://github.com/apache/beam/pull/23092#issuecomment-1241016845
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #23092: Cross-langauge tests in github actions.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #23092:
URL: https://github.com/apache/beam/pull/23092#issuecomment-1240952165
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org