[GitHub] spark pull request: [SPARK-10149] [CORE] [WIP] Locality Level is a...

[srowen <gi...@git.apache.org>]

Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/8533#issuecomment-136638964
  
    (I'm Sean) As I say, the problem with changing `Utils` is that you reintroduce problems elsewhere in the code. See the pull request I mentioned. A flag wouldn't help, right? if you change the behavior, it still causes a problem.
    
    The root problem is that the worker is not returning the IP or host name that you think it should. At some level, you have to choose this if you need to choose this, so I don't see why `SPARK_LOCAL_HOSTNAME` is better or worse. I also don't understand why the host name is the one you want -- it may happen to be in your case, but this doesn't get at the more fundamental issue, that it need not be.
    
    Aren't you really just trying to better identify when two different identifiers for a host are the same? that's not the way to solve this then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org