You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/26 00:39:08 UTC

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #19013: Numpy Pooling and ROI Pooling Large Dimension Checks

wkcn commented on a change in pull request #19013:
URL: https://github.com/apache/incubator-mxnet/pull/19013#discussion_r476918170



##########
File path: src/operator/nn/pooling.cc
##########
@@ -117,6 +117,11 @@ static bool PoolingShape(const nnvm::NodeAttrs &attrs,
       << " Or 4D in (batch, channel, y, x) "
       << " Or 5D in (batch, channel, d, y, x)";
 
+  for (int i=0; i<dshape.ndim(); i++) {
+    CHECK_LT(dshape[i], (int64_t{1} << 31) - 1) << 

Review comment:
       We can replace `(int64_t{1} << 31) - 1` with `INT32_MAX`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org