You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Tobi Knaup <to...@knaup.me> on 2014/10/02 02:19:03 UTC
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 12:19 a.m.)
Review request for mesos.
Changes
-------
Addressing feedback: add a blurb to explain the new field, add a test for the JSON API.
Bugs: MESOS-1828
https://issues.apache.org/jira/browse/MESOS-1828
Repository: mesos-git
Description
-------
Allows frameworks to register a URL to its web UI.
Diffs (updated)
-----
include/mesos/mesos.proto be45494
src/master/http.cpp 41d91c8
src/tests/master_tests.cpp 1497db2
src/webui/master/static/framework.html f6cce02
src/webui/master/static/frameworks.html b11d71a
Diff: https://reviews.apache.org/r/26125/diff/
Testing
-------
Connected a framework with and without webui_url set and checked the web ui.
Thanks,
Tobi Knaup
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/#review55182
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26125]
All tests passed.
- Mesos ReviewBot
On Oct. 2, 2014, 12:19 a.m., Tobi Knaup wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26125/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 12:19 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1828
> https://issues.apache.org/jira/browse/MESOS-1828
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allows frameworks to register a URL to its web UI.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto be45494
> src/master/http.cpp 41d91c8
> src/tests/master_tests.cpp 1497db2
> src/webui/master/static/framework.html f6cce02
> src/webui/master/static/frameworks.html b11d71a
>
> Diff: https://reviews.apache.org/r/26125/diff/
>
>
> Testing
> -------
>
> Connected a framework with and without webui_url set and checked the web ui.
>
>
> Thanks,
>
> Tobi Knaup
>
>
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/#review55229
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 2, 2014, 9:10 a.m., Tobi Knaup wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26125/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 9:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1828
> https://issues.apache.org/jira/browse/MESOS-1828
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allows frameworks to register a URL to its web UI.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto be45494
> src/master/http.cpp 41d91c8
> src/tests/master_tests.cpp 1497db2
> src/webui/master/static/framework.html f6cce02
> src/webui/master/static/frameworks.html b11d71a
>
> Diff: https://reviews.apache.org/r/26125/diff/
>
>
> Testing
> -------
>
> Connected a framework with and without webui_url set and checked the web ui.
>
>
> Thanks,
>
> Tobi Knaup
>
>
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/#review55224
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26125]
All tests passed.
- Mesos ReviewBot
On Oct. 2, 2014, 4:10 p.m., Tobi Knaup wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26125/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 4:10 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1828
> https://issues.apache.org/jira/browse/MESOS-1828
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allows frameworks to register a URL to its web UI.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto be45494
> src/master/http.cpp 41d91c8
> src/tests/master_tests.cpp 1497db2
> src/webui/master/static/framework.html f6cce02
> src/webui/master/static/frameworks.html b11d71a
>
> Diff: https://reviews.apache.org/r/26125/diff/
>
>
> Testing
> -------
>
> Connected a framework with and without webui_url set and checked the web ui.
>
>
> Thanks,
>
> Tobi Knaup
>
>
Re: Review Request 26125: Add webui_url to FrameworkInfo and web UI
Posted by Tobi Knaup <to...@knaup.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 4:10 p.m.)
Review request for mesos.
Changes
-------
Minor cleanup in the test
Bugs: MESOS-1828
https://issues.apache.org/jira/browse/MESOS-1828
Repository: mesos-git
Description
-------
Allows frameworks to register a URL to its web UI.
Diffs (updated)
-----
include/mesos/mesos.proto be45494
src/master/http.cpp 41d91c8
src/tests/master_tests.cpp 1497db2
src/webui/master/static/framework.html f6cce02
src/webui/master/static/frameworks.html b11d71a
Diff: https://reviews.apache.org/r/26125/diff/
Testing
-------
Connected a framework with and without webui_url set and checked the web ui.
Thanks,
Tobi Knaup