You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by moul <gi...@git.apache.org> on 2016/05/14 19:38:49 UTC
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
GitHub user moul opened a pull request:
https://github.com/apache/cloudstack/pull/1548
Compabitility fix for Docker >= 1.11 (docker/docker#19490)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/moul/cloudstack patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
----
commit becdd3460499c2a6c56793b794207715aebd6cb5
Author: Manfred Touron <m...@42.am>
Date: 2016-05-14T19:38:42Z
Compabitility fix for Docker >= 1.11 (docker/docker#19490)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1548: Compabitility fix for Docker >= 1.11 (docker/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1548: Compabitility fix for Docker >= 1.11 (docker/docker#...
Posted by moul <gi...@git.apache.org>.
Github user moul commented on the issue:
https://github.com/apache/cloudstack/pull/1548
Rebased for Travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-219651953
LGTM
Very simple Docker fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1548: Compabitility fix for Docker >= 1.11 (docker/docker#...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1548
merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1548: Compabitility fix for Docker >= 1.11 (docker/docker#...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1548
### ACS CI BVT Run
**Sumarry:**
Build Number 190
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failing since 2 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1548: Compabitility fix for Docker >= 1.11 (docker/docker#...
Posted by dmabry <gi...@git.apache.org>.
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1548
LGTM based code review. This is a very straight forward change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
Posted by moul <gi...@git.apache.org>.
Github user moul commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221256635
@swill, this solution is backward compatible, the `.dockerinit` file always cohabited with `.dockerenv`, until recently, `.dockerinit` was removed while `.dockerenv` is still there
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221284250
@moul can you close and reopen the PR or rebase and force push in order to kick off Jenkins again so we can get this all green?
@pdion891 I think you have spent enough time with Docker to give me the the missing LGTM vote. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-219793684
@moul can you post some verification that this fix works?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Compabitility fix for Docker >= 1.11 (doc...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221301992
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---