You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 16:56:42 UTC

[GitHub] [arrow-datafusion] rdettai opened a new pull request #613: [fix] select * on empty table

rdettai opened a new pull request #613:
URL: https://github.com/apache/arrow-datafusion/pull/613


   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #612.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   The pushdown is forced even for `select *` in https://github.com/apache/arrow-datafusion/blob/20f6f21ec551f066fd9ff228cc5221f1068c8b03/datafusion/src/optimizer/projection_push_down.rs#L164-L170. In that case, we should ensure that no column is artificially added if the table is empty.
   
   # What changes are included in this PR?
   I added the test at the context level because it allows it to have a wider coverage of this corner case.
   
   # Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on pull request #613: [fix] select * on empty table

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #613:
URL: https://github.com/apache/arrow-datafusion/pull/613#issuecomment-867132029


   Thanks @rdettai !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan merged pull request #613: [fix] select * on empty table

Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #613:
URL: https://github.com/apache/arrow-datafusion/pull/613


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org