[GitHub] [hop] nadment opened a new pull request, #2247: Fix Group By Concatenate string separated by new line (CRLF) #2243

["nadment (via GitHub)" <gi...@apache.org>]

nadment opened a new pull request, #2247:
URL: https://github.com/apache/hop/pull/2247

   I wrote a unit test, but didn't push it because I think CRLFs are not compatible between Linux/Windows and Mac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva merged pull request #2247: Fix Group By Concatenate string separated by new line (CRLF) #2243

["hansva (via GitHub)" <gi...@apache.org>]

hansva merged PR #2247:
URL: https://github.com/apache/hop/pull/2247


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hop] hansva commented on pull request #2247: Fix Group By Concatenate string separated by new line (CRLF) #2243

["hansva (via GitHub)" <gi...@apache.org>]

hansva commented on PR #2247:
URL: https://github.com/apache/hop/pull/2247#issuecomment-1419855018

   Can you push it anyway? We can add a condition for windows/Linux systems if needed and more tests are always helpful 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org