You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2006/09/25 17:50:25 UTC
svn commit: r449710 -
/james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
Author: norman
Date: Mon Sep 25 08:50:24 2006
New Revision: 449710
URL: http://svn.apache.org/viewvc?view=rev&rev=449710
Log:
Change SoftFail to Neutral.. Thx to Guillermo Grandes for reporting
Modified:
james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
Modified: james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java?view=diff&rev=449710&r1=449709&r2=449710
==============================================================================
--- james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java (original)
+++ james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java Mon Sep 25 08:50:24 2006
@@ -47,7 +47,7 @@
public static final String DEFAULT_EXPLANATION = "http://www.openspf.org/why.html?sender=%{S}&ip=%{I}";
- public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr ~all";
+ public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr";
/**
* Convert raw SPF results to SPF names
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r449710 - /james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
Posted by Guillermo Grandes <gu...@gmail.com>.
... you forgot the "?all" !! :-)
- public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr ~all";
+ public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr";
must be: "a/24 mx/24 ptr ?all" ;-)
it lacks the "v=spf1 ..."? or getSpfRecord() return without this?
----- Original Message -----
From: <no...@apache.org>
To: <se...@james.apache.org>
Sent: Monday, September 25, 2006 5:50 PM
Subject: svn commit: r449710 -
/james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
> Author: norman
> Date: Mon Sep 25 08:50:24 2006
> New Revision: 449710
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=449710
> Log:
> Change SoftFail to Neutral.. Thx to Guillermo Grandes for reporting
>
> Modified:
> james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
>
> Modified:
> james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
> URL:
> http://svn.apache.org/viewvc/james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java?view=diff&rev=449710&r1=449709&r2=449710
> ==============================================================================
> --- james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
> (original)
> +++ james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
> Mon Sep 25 08:50:24 2006
> @@ -47,7 +47,7 @@
>
> public static final String DEFAULT_EXPLANATION =
> "http://www.openspf.org/why.html?sender=%{S}&ip=%{I}";
>
> - public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr ~all";
> + public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr";
>
> /**
> * Convert raw SPF results to SPF names
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: svn commit: r449710 - /james/jspf/trunk/src/main/java/org/apache/james/jspf/SPF1Utils.java
Posted by Norman Maurer <nm...@byteaction.de>.
Guillermo Grandes schrieb:
> ... you forgot the "?all" !! :-)
Well that is not so importend cause we set it to neutral as default if
no match was found. But anyway i added it now.
>
> - public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr
> ~all";
> + public static final String BEST_GUESS_RECORD = "a/24 mx/24 ptr";
>
> must be: "a/24 mx/24 ptr ?all" ;-)
>
> it lacks the "v=spf1 ..."? or getSpfRecord() return without this?
I think sometimes it whould be better todo no commits :-P I fixed it.
Thx again.
bye
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org