You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/14 15:36:22 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #9530:
[charts] adds new filters ui
nytai opened a new pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410388327
##########
File path: superset/charts/dao.py
##########
@@ -51,3 +56,25 @@ def bulk_delete(models: Optional[List[Slice]], commit: bool = True) -> None:
if commit:
db.session.rollback()
raise ex
+
+ @staticmethod
+ def fetch_unique_column_values(column_name: str) -> List:
+ return [
+ val[0]
+ for val in db.session.query(getattr(Slice, column_name)).distinct().all()
+ ]
+
+ @staticmethod
+ def fetch_unique_datasources() -> Optional[List["BaseDatasource"]]:
Review comment:
This looks fine, but UX note: It might be confusing to only be able to filter by datasources that are used in charts. Using a list of all datasources and handling unused ones with an empty state might be more ideal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `4.78%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 65.63% -4.79%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
- Hits 21140 19734 -1406
- Misses 8767 10146 +1379
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [137 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.23% -0.20%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12413 -8727
+ Misses 8767 5261 -3506
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [389 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.23% -0.20%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12413 -8727
+ Misses 8767 5261 -3506
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.81%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.60% -6.82%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18312 -2828
- Misses 8767 10284 +1517
- Partials 111 194 +83
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.71% <ø> (-0.82%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410429429
##########
File path: superset/charts/dao.py
##########
@@ -51,3 +56,25 @@ def bulk_delete(models: Optional[List[Slice]], commit: bool = True) -> None:
if commit:
db.session.rollback()
raise ex
+
+ @staticmethod
+ def fetch_unique_column_values(column_name: str) -> List:
+ return [
+ val[0]
+ for val in db.session.query(getattr(Slice, column_name)).distinct().all()
+ ]
+
+ @staticmethod
+ def fetch_unique_datasources() -> Optional[List["BaseDatasource"]]:
Review comment:
That's a good point. I originally implemented the viz_types by checking unique vals in the db, which ended up informing the decision to go with this implementation. Going to see if if there's a way to collect available viz types instead of relying on created ones...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #9530: [charts] adds
new filters ui
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615426370
@ktmud I attached a screenshot. While this is a UI change, it's off by default. To see it you'll need to enable the config `ENABLE_REACT_CRUD_VIEWS` and the feature flag `LIST_VIEWS_NEW_UI`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `68.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
=======================================
Coverage 70.42% 70.42%
=======================================
Files 571 571
Lines 30018 30063 +45
Branches 3042 3049 +7
=======================================
+ Hits 21140 21172 +32
- Misses 8767 8778 +11
- Partials 111 113 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <ø> (+0.05%)` | :arrow_up: |
| #javascript | `58.72% <31.57%> (-0.05%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.31% <31.57%> (-5.74%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
+ Coverage 70.42% 70.45% +0.02%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12452 -8688
+ Misses 8767 5222 -3545
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/showSavedQuery/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L2luZGV4LmpzeA==) | | |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
| [superset-frontend/src/profile/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLmpzeA==) | | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy5qcw==) | | |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | | |
| ... and [380 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410388327
##########
File path: superset/charts/dao.py
##########
@@ -51,3 +56,25 @@ def bulk_delete(models: Optional[List[Slice]], commit: bool = True) -> None:
if commit:
db.session.rollback()
raise ex
+
+ @staticmethod
+ def fetch_unique_column_values(column_name: str) -> List:
+ return [
+ val[0]
+ for val in db.session.query(getattr(Slice, column_name)).distinct().all()
+ ]
+
+ @staticmethod
+ def fetch_unique_datasources() -> Optional[List["BaseDatasource"]]:
Review comment:
This looks fine, but UX note: It might be confusing to only be able to filter by datasources that are used in charts. Using a list of all datasources and handling unused ones with an empty state in the UI might be more ideal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.41% -0.02%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
+ Hits 21140 21170 +30
- Misses 8767 8783 +16
- Partials 111 113 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.53% <ø> (ø)` | |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `68.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 65.62% -4.81%
==========================================
Files 571 571
Lines 30018 30063 +45
Branches 3042 3049 +7
==========================================
- Hits 21140 19728 -1412
- Misses 8767 10149 +1382
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.72% <31.57%> (-0.05%)` | :arrow_down: |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.31% <31.57%> (-5.74%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...4319e32](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.39% -0.04%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12441 -8699
+ Misses 8767 5233 -3534
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.39% <93.10%> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.32% <0.00%> (-0.77%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-0.30%)` | :arrow_down: |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Ryb3BPdmVyZmxvd3NQYXJlbnQuanM=) | | |
| ... and [385 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `68.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 65.49% -4.94%
==========================================
Files 571 571
Lines 30018 30063 +45
Branches 3042 3049 +7
==========================================
- Hits 21140 19689 -1451
- Misses 8767 10188 +1421
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.72% <31.57%> (-0.05%)` | :arrow_down: |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.31% <31.57%> (-5.74%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...4319e32](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `68.75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.19% -0.23%
==========================================
Files 571 571
Lines 30018 30063 +45
Branches 3042 3049 +7
==========================================
- Hits 21140 21104 -36
- Misses 8767 8839 +72
- Partials 111 120 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.68% <ø> (-0.85%)` | :arrow_down: |
| #javascript | `58.72% <31.57%> (-0.05%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.31% <31.57%> (-5.74%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...4319e32](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.82%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.60% -6.83%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18311 -2829
- Misses 8767 10285 +1518
- Partials 111 194 +83
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.70% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 65.61% -4.81%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
- Hits 21140 19728 -1412
- Misses 8767 10152 +1385
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.52%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.89% -6.53%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18396 -2744
- Misses 8767 10210 +1443
- Partials 111 184 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.57% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `70.39% <93.10%> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.19% -0.23%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
- Hits 21140 21105 -35
- Misses 8767 8841 +74
- Partials 111 120 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.70% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9530: [charts]
adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.23% -0.20%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12413 -8727
+ Misses 8767 5261 -3506
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410364600
##########
File path: superset-frontend/src/views/chartList/ChartList.tsx
##########
@@ -311,11 +320,24 @@ class ChartList extends React.PureComponent<Props, State> {
},
loading: true,
});
- const filterExps = filters.map(({ id: col, operator: opr, value }) => ({
- col,
- opr,
- value,
- }));
+ const filterExps = filters
+ .map(({ id: col, operator: opr, value }) => ({
+ col,
+ opr,
+ value,
+ }))
+ .reduce((acc, fltr) => {
+ if (fltr.col === 'datasource' && typeof fltr.value === 'object') {
Review comment:
checking `fltr. value === 'object'` will be true if the value is null, is that intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410367449
##########
File path: superset-frontend/src/views/chartList/ChartList.tsx
##########
@@ -311,11 +320,24 @@ class ChartList extends React.PureComponent<Props, State> {
},
loading: true,
});
- const filterExps = filters.map(({ id: col, operator: opr, value }) => ({
- col,
- opr,
- value,
- }));
+ const filterExps = filters
+ .map(({ id: col, operator: opr, value }) => ({
+ col,
+ opr,
+ value,
+ }))
+ .reduce((acc, fltr) => {
+ if (fltr.col === 'datasource' && typeof fltr.value === 'object') {
Review comment:
there's another null check bellow. I'll move it up here so it's more visible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.51%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.91% -6.52%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18400 -2740
- Misses 8767 10206 +1439
- Partials 111 184 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.50% <ø> (-0.03%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.48%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.93% -6.49%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18408 -2732
- Misses 8767 10198 +1431
- Partials 111 184 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <ø> (+0.04%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `70.45% <93.10%> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.19% -0.23%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
- Hits 21140 21105 -35
- Misses 8767 8841 +74
- Partials 111 120 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.70% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.48% <93.10%> (+0.03%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9530: [charts] adds
new filters ui
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615391954
Would be nice to have some screenshots if this is a UI change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `11.69%`.
> The diff coverage is `31.57%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
===========================================
- Coverage 70.42% 58.72% -11.70%
===========================================
Files 571 389 -182
Lines 30018 12389 -17629
Branches 3042 3049 +7
===========================================
- Hits 21140 7276 -13864
+ Misses 8767 4927 -3840
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.72% <31.57%> (-0.05%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `60.31% <31.57%> (-5.74%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [313 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...4319e32](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `6.86%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 63.56% -6.87%
==========================================
Files 571 523 -48
Lines 30018 28790 -1228
Branches 3042 2741 -301
==========================================
- Hits 21140 18300 -2840
- Misses 8767 10296 +1529
- Partials 111 194 +83
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.70% <ø> (-0.83%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `70.39% <93.10%> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#discussion_r410387963
##########
File path: superset/charts/api.py
##########
@@ -493,3 +502,97 @@ def add_apispec_components(self, api_spec: APISpec) -> None:
chart_type.__name__, schema=chart_type,
)
super().add_apispec_components(api_spec)
+
+ @expose("/viz_types", methods=["GET"])
+ @protect()
+ @safe
+ def viz_types(self) -> Response:
+ """Get unique viz_type values
+ ---
+ get:
+ responses:
+ 200:
+ description: charts unique viz_type data
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ count:
+ type: integer
+ result:
+ type: object
+ properties:
+ label:
+ type: string
+ value:
+ type: string
+ 400:
+ $ref: '#/components/responses/400'
+ 401:
+ $ref: '#/components/responses/401'
+ 404:
+ $ref: '#/components/responses/404'
+ 500:
+ $ref: '#/components/responses/500'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ values = ChartDAO.fetch_unique_column_values("viz_type")
+ result = [{"label": val, "value": val} for val in values]
+ return self.response(200, count=len(result), result=result)
+
+ @expose("/datasources", methods=["GET"])
+ @protect()
+ @safe
+ def datasources(self) -> Response:
+ """Get unique viz_type values
Review comment:
```suggestion
"""Get unique datasource values
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530:
[charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `64.70%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 65.48% -4.94%
==========================================
Files 571 571
Lines 30018 30066 +48
Branches 3042 3051 +9
==========================================
- Hits 21140 19689 -1451
- Misses 8767 10191 +1424
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.71% <27.27%> (-0.07%)` | :arrow_down: |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `58.91% <27.27%> (-7.15%)` | :arrow_down: |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...b51ec9d](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530:
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 69.89% -0.53%
==========================================
Files 571 392 -179
Lines 30018 12450 -17568
Branches 3042 3066 +24
==========================================
- Hits 21140 8702 -12438
+ Misses 8767 3629 -5138
- Partials 111 119 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.88% <ø> (-0.65%)` | :arrow_down: |
| #javascript | `58.71% <57.14%> (-0.07%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.50% <52.77%> (-3.56%)` | :arrow_down: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `77.35% <64.70%> (-7.43%)` | :arrow_down: |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...afbc112](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530:
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/083dd6ae1a53f6177b7ce16e9c914fd2d790aeec&el=desc) will **decrease** coverage by `11.71%`.
> The diff coverage is `66.07%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
===========================================
- Coverage 70.47% 58.76% -11.72%
===========================================
Files 574 392 -182
Lines 30079 12450 -17629
Branches 3054 3066 +12
===========================================
- Hits 21199 7316 -13883
+ Misses 8768 4950 -3818
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.76% <66.07%> (+<0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.50% <52.77%> (-3.56%)` | :arrow_down: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `88.67% <94.11%> (+3.89%)` | :arrow_up: |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [319 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [083dd6a...e699026](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9530:
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-616854376
@mistercrunch Do you see any reason I'm not allowed to merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530:
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.41% -0.01%
==========================================
Files 571 392 -179
Lines 30018 12450 -17568
Branches 3042 3066 +24
==========================================
- Hits 21140 8767 -12373
+ Misses 8767 3571 -5196
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (+0.17%)` | :arrow_up: |
| #javascript | `58.71% <57.14%> (-0.07%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.50% <52.77%> (-3.56%)` | :arrow_down: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `77.35% <64.70%> (-7.43%)` | :arrow_down: |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/Heatmap.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9IZWF0bWFwLmpz) | `100.00% <0.00%> (ø)` | |
| [...et-frontend/src/explore/controlPanels/LineMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9MaW5lTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | | |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...afbc112](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9530: [charts] adds new filters ui
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9530:
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `11.70%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
===========================================
- Coverage 70.42% 58.71% -11.71%
===========================================
Files 571 392 -179
Lines 30018 12450 -17568
Branches 3042 3066 +24
===========================================
- Hits 21140 7310 -13830
+ Misses 8767 4955 -3812
- Partials 111 185 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.71% <57.14%> (-0.07%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `54.62% <ø> (ø)` | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.50% <52.77%> (-3.56%)` | :arrow_down: |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `77.35% <64.70%> (-7.43%)` | :arrow_down: |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [322 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...afbc112](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org