You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/19 14:11:35 UTC
[GitHub] [shardingsphere-elasticjob] wwj-go opened a new pull request #1614: Finish document for job error handler #1581
wwj-go opened a new pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614
Fixes #1581.
Changes proposed in this pull request:
- Finish document for job error handler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on a change in pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
wwj-go commented on a change in pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#discussion_r507787244
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/built-in-strategy/error-handler.en.md
##########
@@ -81,11 +81,11 @@ Maven POM:
Configuration:
-| Name | Description | Default Value |
-| ------------------------- |:----------- |:----------------- |
-| webhook | TODO | None |
-| connectTimeoutMillisecond | TODO | 3000 milliseconds |
-| readTimeoutMillisecond | TODO | 5000 milliseconds |
+| Name | Description | Default Value |
+| -------------------------------- |:---------------------------------------------------------------------------|:----------------- |
+| wechat.webhook | The webhook address of the wechat robot | None |
+| wechat.connectTimeoutMillisecond | The timeout period for establishing a connection with the wechat server | 3000 milliseconds |
+| wechat.readTimeoutMillisecond | The timeout period for reading available resources from the wechat server | 5000 milliseconds |
Review comment:
That is a HTTP response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#discussion_r507803770
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/built-in-strategy/error-handler.cn.md
##########
@@ -47,19 +47,18 @@ Maven 坐标：
可配置属性：
-| 属性名 | 说明 | 默认值 |
-| -------------- |:----------- |:------------------------ |
-| email.host | TODO | 无 |
-| email.port | TODO | 无 |
-| email.username | TODO | 无 |
-| email.password | TODO | 无 |
-| email.useSsl | TODO | true |
-| email.subject | TODO | ElasticJob error message |
-| email.from | TODO | 无 |
-| email.to | TODO | 无 |
-| email.cc | TODO | 无 |
-| email.bcc | TODO | 无 |
-| email.debug | TODO | false |
+| 属性名 | 说明 | 默认值 |
+| -------- |:-------------------- |:------------------------ |
+| host | 邮件服务主机地址 | 无 |
+| port | 邮件服务主机端口 | 无 |
+| username | 用户名 | 无 |
+| password | 密码 | 无 |
+| useSsl | 是否启用ssl加密传输 | 无 |
Review comment:
There is default value here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#issuecomment-712240141
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=h1) Report
> Merging [#1614](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/727b1cbf3b2f53f0193b18701e00d9b5611d122c?el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1614 +/- ##
============================================
- Coverage 85.41% 85.38% -0.04%
Complexity 105 105
============================================
Files 253 253
Lines 5657 5657
Branches 878 878
============================================
- Hits 4832 4830 -2
Misses 511 511
- Partials 314 316 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `96.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ring/boot/job/ElasticJobLiteAutoConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1zcHJpbmcvZWxhc3RpY2pvYi1saXRlLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvbGl0ZS9zcHJpbmcvYm9vdC9qb2IvRWxhc3RpY0pvYkxpdGVBdXRvQ29uZmlndXJhdGlvbi5qYXZh) | `56.00% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
| [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `100.00% <0.00%> (+20.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=footer). Last update [727b1cb...b712fd6](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1614?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on a change in pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
wwj-go commented on a change in pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#discussion_r507789458
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/built-in-strategy/error-handler.en.md
##########
@@ -81,11 +81,11 @@ Maven POM:
Configuration:
-| Name | Description | Default Value |
-| ------------------------- |:----------- |:----------------- |
-| webhook | TODO | None |
-| connectTimeoutMillisecond | TODO | 3000 milliseconds |
-| readTimeoutMillisecond | TODO | 5000 milliseconds |
+| Name | Description | Default Value |
+| -------------------------------- |:---------------------------------------------------------------------------|:----------------- |
+| wechat.webhook | The webhook address of the wechat robot | None |
+| wechat.connectTimeoutMillisecond | The timeout period for establishing a connection with the wechat server | 3000 milliseconds |
+| wechat.readTimeoutMillisecond | The timeout period for reading available resources from the wechat server | 5000 milliseconds |
Review comment:
For wechat and dingTalk，we send the error message to a URL named webhook by HTTP POST method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#discussion_r507785108
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/built-in-strategy/error-handler.en.md
##########
@@ -81,11 +81,11 @@ Maven POM:
Configuration:
-| Name | Description | Default Value |
-| ------------------------- |:----------- |:----------------- |
-| webhook | TODO | None |
-| connectTimeoutMillisecond | TODO | 3000 milliseconds |
-| readTimeoutMillisecond | TODO | 5000 milliseconds |
+| Name | Description | Default Value |
+| -------------------------------- |:---------------------------------------------------------------------------|:----------------- |
+| wechat.webhook | The webhook address of the wechat robot | None |
+| wechat.connectTimeoutMillisecond | The timeout period for establishing a connection with the wechat server | 3000 milliseconds |
+| wechat.readTimeoutMillisecond | The timeout period for reading available resources from the wechat server | 5000 milliseconds |
Review comment:
How to understand "available resources"? Is that HTTP response?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] wwj-go commented on a change in pull request #1614: Finish document for job error handler #1581
Posted by GitBox <gi...@apache.org>.
wwj-go commented on a change in pull request #1614:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1614#discussion_r507808163
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/built-in-strategy/error-handler.cn.md
##########
@@ -47,19 +47,18 @@ Maven 坐标：
可配置属性：
-| 属性名 | 说明 | 默认值 |
-| -------------- |:----------- |:------------------------ |
-| email.host | TODO | 无 |
-| email.port | TODO | 无 |
-| email.username | TODO | 无 |
-| email.password | TODO | 无 |
-| email.useSsl | TODO | true |
-| email.subject | TODO | ElasticJob error message |
-| email.from | TODO | 无 |
-| email.to | TODO | 无 |
-| email.cc | TODO | 无 |
-| email.bcc | TODO | 无 |
-| email.debug | TODO | false |
+| 属性名 | 说明 | 默认值 |
+| -------- |:-------------------- |:------------------------ |
+| host | 邮件服务主机地址 | 无 |
+| port | 邮件服务主机端口 | 无 |
+| username | 用户名 | 无 |
+| password | 密码 | 无 |
+| useSsl | 是否启用ssl加密传输 | 无 |
Review comment:
I will correct this and other same case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org