[GitHub] dspavlov commented on a change in pull request #5725: IGNITE-10732 Force -Dfile.encoding=UTF-8

[GitBox <gi...@apache.org>]

dspavlov commented on a change in pull request #5725: IGNITE-10732 Force -Dfile.encoding=UTF-8 
URL: https://github.com/apache/ignite/pull/5725#discussion_r244586008
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java
 ##########
 @@ -1387,6 +1392,20 @@ private void validateCommon(IgniteConfiguration cfg) {
         A.ensure(cfg.getNetworkSendRetryCount() > 0, "cfg.getNetworkSendRetryCount() > 0");
     }
 
+    /**
+     * Check whether UTF-8 is the default character encoding.
+     * Differing character encodings across cluster may lead to erratic behavior.
+     */
+    private void checkFileEncoding() {
+        String encodingDisplayName = Charset.defaultCharset().displayName(Locale.ENGLISH);
+
+        if (!"UTF-8".equals(encodingDisplayName)) {
 
 Review comment:
   Probably we can warn user only if we detect different encoding are applied cluster-wide. I'm not sure we should warn here if we did not validate overall settings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services