You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/29 14:51:19 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
gyfora opened a new pull request, #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496
## What is the purpose of the change
The PR adds validation for flinkVersion changes on SUSPENDED application. If the flinkVersion is changed for an application that was suspended with last-state upgrade mode (relying on the HA metadata) this may lead to state loss depending on the flink version.
This validation is necessary to avoid unintentional state loss.
If the user wants to change the flink version in these cases, they first have to restart the job with the old version then perform the upgrade from that state or use a savepoint.
## Brief change log
- *Added required validation & tests*
## Verifying this change
New validator unit tests added to check the version change scenarios.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368285632
> @morhidi i think improving the error message is a good idea and I will do that, but I wouldn’t add detailed instructions / links. This is not common practice I feel and this also isn’t a manual recovery scenario but simply a spec validation error .
But the instructions are so specific ` they first have to restart the job with the old version then perform the upgrade from that state or use a savepoint`. We should do something with it. The users should know how to address the validation error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368283478
@morhidi i think improving the error message is a good idea and I will do that, but I wouldn’t add detailed instructions / links. This is not common practice I feel and this also this is a manual recovery scenario but simply a spec validation error .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368282996
Slightly related: How do you feel @gyfora about adding instructions / a link to instructions for manual restore steps, etc that users are supposed to perform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368282688
Thanks for the PR @gyfora. Regarding:
> If the user wants to change the flink version in these cases, they first have to restart the job with the old version then perform the upgrade from that state or use a savepoint.
We should advise the user to follow these instructions. The validate error could contain this IMO. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368286402
Maybe I just don’t understand what your concrete suggestion is :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368287853
> Maybe I just don’t understand what your concrete suggestion is :)
Just append this to the validation error you already added: `they first have to restart the job with the old version then perform the upgrade from that state or use a savepoint.` Otherwise the users wont know what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368286023
The validation is about the version only, the user can restart the job with the old version but change the spec otherwise. This is not something we should do automatically for an already suspended job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #496: [FLINK-30527] Validate flinkVersion change for suspended jobs
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #496:
URL: https://github.com/apache/flink-kubernetes-operator/pull/496#issuecomment-1368288713
Makes sense, I will do this tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org