You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by su...@apache.org on 2021/08/28 06:40:34 UTC
[echarts] branch release-dev updated (0043798 -> 6083ce5)
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a change to branch release-dev
in repository https://gitbox.apache.org/repos/asf/echarts.git.
from 0043798 fix: add null condition.
add 7890d0e Merge pull request #15612 from apache/release-dev
new 6083ce5 fix: fix lint.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/coord/axisModelCommonMixin.ts | 1 +
src/data/Graph.ts | 1 +
src/data/Tree.ts | 3 ++-
src/label/labelStyle.ts | 4 +---
src/layout/points.ts | 1 -
src/model/Model.ts | 11 ++++++-----
src/util/conditionalExpression.ts | 2 +-
src/visual/style.ts | 2 +-
8 files changed, 13 insertions(+), 12 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[echarts] 01/01: fix: fix lint.
Posted by su...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a commit to branch release-dev
in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 6083ce5e97a0b4aa58e7b5d4f17f3fee5d7ba1ad
Author: sushuang <su...@gmail.com>
AuthorDate: Sat Aug 28 02:39:04 2021 +0800
fix: fix lint.
---
src/coord/axisModelCommonMixin.ts | 1 +
src/data/Graph.ts | 1 +
src/data/Tree.ts | 3 ++-
src/label/labelStyle.ts | 4 +---
src/layout/points.ts | 1 -
src/model/Model.ts | 11 ++++++-----
src/util/conditionalExpression.ts | 2 +-
src/visual/style.ts | 2 +-
8 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/src/coord/axisModelCommonMixin.ts b/src/coord/axisModelCommonMixin.ts
index 4550618..2c3bbc5 100644
--- a/src/coord/axisModelCommonMixin.ts
+++ b/src/coord/axisModelCommonMixin.ts
@@ -27,6 +27,7 @@ interface AxisModelCommonMixin<Opt extends AxisBaseOption> extends Pick<Model<Op
axis: Axis;
}
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
class AxisModelCommonMixin<Opt extends AxisBaseOption> {
getNeedCrossZero(): boolean {
diff --git a/src/data/Graph.ts b/src/data/Graph.ts
index 4605ff1..6ebb2ca 100644
--- a/src/data/Graph.ts
+++ b/src/data/Graph.ts
@@ -412,6 +412,7 @@ class GraphEdge {
getModel<T = unknown>(): Model<T>
getModel<T = unknown, S extends keyof T= keyof T>(path: S): Model<T[S]>
+ // eslint-disable-next-line @typescript-eslint/no-unused-vars
getModel<T = unknown>(path?: string): Model {
if (this.dataIndex < 0) {
return;
diff --git a/src/data/Tree.ts b/src/data/Tree.ts
index 0389f6a..3b5d4a7 100644
--- a/src/data/Tree.ts
+++ b/src/data/Tree.ts
@@ -228,6 +228,7 @@ export class TreeNode {
getModel<T = unknown>(): Model<T>
// @depcrecated
// getModel<T = unknown, S extends keyof T = keyof T>(path: S): Model<T[S]>
+ // eslint-disable-next-line @typescript-eslint/no-unused-vars
getModel<T = unknown>(path?: string): Model {
if (this.dataIndex < 0) {
return;
@@ -412,7 +413,7 @@ class Tree<HostModel extends Model = Model, LevelOption = any> {
* ]
* }
*/
- static createTree<T extends TreeNodeOption, HostModel extends Model, LevelOption>(
+ static createTree<T extends TreeNodeOption, HostModel extends Model>(
dataRoot: T,
hostModel: HostModel,
beforeLink?: (data: SeriesData) => void
diff --git a/src/label/labelStyle.ts b/src/label/labelStyle.ts
index 606aa94..e63a351 100644
--- a/src/label/labelStyle.ts
+++ b/src/label/labelStyle.ts
@@ -30,8 +30,7 @@ import {
ColorString,
ZRStyleProps,
AnimationOptionMixin,
- InterpolatableValue,
- SeriesDataType
+ InterpolatableValue
} from '../util/types';
import GlobalModel from '../model/Global';
import { isFunction, retrieve2, extend, keys, trim } from 'zrender/src/core/util';
@@ -40,7 +39,6 @@ import { deprecateReplaceLog } from '../util/log';
import { makeInner, interpolateRawValues } from '../util/model';
import SeriesData from '../data/SeriesData';
import { initProps, updateProps } from '../util/graphic';
-import { getECData } from '../util/innerStore';
type TextCommonParams = {
/**
diff --git a/src/layout/points.ts b/src/layout/points.ts
index bde24f1..0b06040 100644
--- a/src/layout/points.ts
+++ b/src/layout/points.ts
@@ -17,7 +17,6 @@
* under the License.
*/
-/* global Float32Array */
import {map} from 'zrender/src/core/util';
import createRenderPlanner from '../chart/helper/createRenderPlanner';
diff --git a/src/model/Model.ts b/src/model/Model.ts
index 559c3e9..160c825 100644
--- a/src/model/Model.ts
+++ b/src/model/Model.ts
@@ -36,12 +36,13 @@ import { mixin, clone, merge } from 'zrender/src/core/util';
// Since model.option can be not only `Dictionary` but also primary types,
// we do this conditional type to avoid getting type 'never';
-type Key<Opt> = Opt extends Dictionary<any>
- ? keyof Opt : string;
-type Value<Opt, R> = Opt extends Dictionary<any>
- ? (R extends keyof Opt ? Opt[R] : ModelOption)
- : ModelOption;
+// type Key<Opt> = Opt extends Dictionary<any>
+// ? keyof Opt : string;
+// type Value<Opt, R> = Opt extends Dictionary<any>
+// ? (R extends keyof Opt ? Opt[R] : ModelOption)
+// : ModelOption;
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
interface Model<Opt = ModelOption>
extends LineStyleMixin, ItemStyleMixin, TextStyleMixin, AreaStyleMixin {}
class Model<Opt = ModelOption> { // TODO: TYPE use unkown insteadof any?
diff --git a/src/util/conditionalExpression.ts b/src/util/conditionalExpression.ts
index 2d9b752..5107ac5 100644
--- a/src/util/conditionalExpression.ts
+++ b/src/util/conditionalExpression.ts
@@ -167,7 +167,7 @@ interface RelationalExpressionOption extends
parser?: RawValueParserType;
}
-type RelationalExpressionOpEvaluate = (tarVal: unknown, condVal: unknown) => boolean;
+// type RelationalExpressionOpEvaluate = (tarVal: unknown, condVal: unknown) => boolean;
class RegExpEvaluator implements FilterComparator {
diff --git a/src/visual/style.ts b/src/visual/style.ts
index 8683a21..e791189 100644
--- a/src/visual/style.ts
+++ b/src/visual/style.ts
@@ -18,7 +18,7 @@
*/
import { isFunction, extend, createHashMap } from 'zrender/src/core/util';
-import { StageHandler, CallbackDataParams, ZRColor, Dictionary, InnerDecalObject, SeriesOption }
+import { StageHandler, CallbackDataParams, ZRColor, Dictionary, InnerDecalObject }
from '../util/types';
import makeStyleMapper from '../model/mixin/makeStyleMapper';
import { ITEM_STYLE_KEY_MAP } from '../model/mixin/itemStyle';
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org