You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "whutpencil (via GitHub)" <gi...@apache.org> on 2023/11/24 01:45:47 UTC
[PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
whutpencil opened a new pull request, #27515:
URL: https://github.com/apache/doris/pull/27515
## Proposed changes
Issue Number: close #xxx
The old logic used to determine whether it was a partition table based on the number of buckets, but if I had a partition table with only one partition and the number of buckets in that partition was 1, it would be mistakenly recognized as a non partition table.
```
Table[test_load_doris_to_hive_2] is not partitioned
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27515:
URL: https://github.com/apache/doris/pull/27515#issuecomment-1825132706
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.38 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17099390689 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27515:
URL: https://github.com/apache/doris/pull/27515#issuecomment-1825137975
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 53b97c7b1d251c065f1d2d73b2e09c13cdb806b0, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4909 4689 4651 4651
q2 373 141 159 141
q3 2037 1909 1860 1860
q4 1385 1262 1220 1220
q5 3941 3909 4045 3909
q6 245 129 126 126
q7 1452 879 868 868
q8 2770 2769 2760 2760
q9 9917 12702 9399 9399
q10 3476 3531 3525 3525
q11 396 246 245 245
q12 445 294 294 294
q13 4564 3806 3746 3746
q14 333 294 289 289
q15 590 531 528 528
q16 679 588 580 580
q17 1144 932 913 913
q18 7827 7446 7383 7383
q19 1674 1675 1695 1675
q20 530 304 319 304
q21 4404 3954 3942 3942
q22 478 372 366 366
Total cold run time: 53569 ms
Total hot run time: 48724 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4562 4560 4585 4560
q2 356 229 264 229
q3 4020 3995 4008 3995
q4 2698 2716 2695 2695
q5 9713 9754 9618 9618
q6 243 117 118 117
q7 3010 2459 2489 2459
q8 4418 4449 4439 4439
q9 12908 12866 12893 12866
q10 4076 4147 4196 4147
q11 749 672 644 644
q12 976 821 808 808
q13 4288 3565 3616 3565
q14 402 366 350 350
q15 572 521 521 521
q16 743 671 682 671
q17 3931 3935 3868 3868
q18 9476 9059 9106 9059
q19 1833 1767 1779 1767
q20 2393 2046 2036 2036
q21 8718 8616 8507 8507
q22 939 870 829 829
Total cold run time: 81024 ms
Total hot run time: 77750 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27515:
URL: https://github.com/apache/doris/pull/27515#issuecomment-1827601248
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #27515:
URL: https://github.com/apache/doris/pull/27515#issuecomment-1825076323
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #27515:
URL: https://github.com/apache/doris/pull/27515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](judge-partition) Fix incorrect logic in determining partitioned table [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27515:
URL: https://github.com/apache/doris/pull/27515#issuecomment-1827601323
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org