You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/30 05:34:48 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #6654: Resolve envoy service name from a different position
hanahmily opened a new pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654
* Using "service.istio.io/canonical-name" to replace "app" label to resolve service name
* Improving FieldsHelper to support dot in labels
Fixed #6647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.99%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.43% -1.00%
+ Complexity 4191 4123 -68
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14404 -316
- Misses 9190 9439 +249
+ Partials 1282 1237 -45
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [42 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.52%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.91% -0.53%
+ Complexity 4191 4139 -52
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14524 -196
- Misses 9190 9293 +103
+ Partials 1282 1263 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/influxdb/query/BrowserLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ccm93c2VyTG9nUXVlcnkuamF2YQ==) | `2.17% <0.00%> (-58.70%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `5.06%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.71% 52.65% -5.07%
+ Complexity 4152 3815 -337
============================================
Files 1005 999 -6
Lines 25192 25052 -140
Branches 2456 2448 -8
============================================
- Hits 14540 13190 -1350
- Misses 9380 10740 +1360
+ Partials 1272 1122 -150
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [118 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `18.42%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 54.95% 36.52% -18.43%
+ Complexity 3951 2194 -1757
=============================================
Files 1005 813 -192
Lines 25152 20164 -4988
Branches 2454 1912 -542
=============================================
- Hits 13822 7365 -6457
- Misses 10171 12247 +2076
+ Partials 1159 552 -607
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [420 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `7.82%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 54.83% +7.82%
- Complexity 3028 3990 +962
============================================
Files 1796 999 -797
Lines 38498 25054 -13444
Branches 4230 2448 -1782
============================================
- Hits 18099 13738 -4361
+ Misses 19398 10139 -9259
- Partials 1001 1177 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.61%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 56.67% -1.62%
+ Complexity 4177 4090 -87
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14684 14208 -476
- Misses 9234 9643 +409
+ Partials 1274 1219 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.80% <0.00%> (-77.31%)` | `2.00% <0.00%> (-11.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `2.46%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 49.48% +2.46%
+ Complexity 3028 2987 -41
============================================
Files 1796 844 -952
Lines 38498 21200 -17298
Branches 4230 2025 -2205
============================================
- Hits 18099 10490 -7609
+ Misses 19398 9885 -9513
+ Partials 1001 825 -176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.95%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 57.33% -0.96%
+ Complexity 4177 4117 -60
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14684 14380 -304
- Misses 9234 9464 +230
+ Partials 1274 1236 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [49 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `1.68%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 42.35% +1.68%
+ Complexity 2837 2553 -284
============================================
Files 973 843 -130
Lines 24196 20985 -3211
Branches 2360 1989 -371
============================================
- Hits 9842 8889 -953
+ Misses 13619 11454 -2165
+ Partials 735 642 -93
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [359 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.95%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 56.33% -1.96%
+ Complexity 4177 4069 -108
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14684 14124 -560
- Misses 9234 9737 +503
+ Partials 1274 1209 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.80% <0.00%> (-77.31%)` | `2.00% <0.00%> (-11.00%)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-75.00%)` | `3.00% <0.00%> (-6.00%)` | |
| ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `9.47%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 56.49% +9.47%
- Complexity 3028 4071 +1043
============================================
Files 1796 999 -797
Lines 38498 25064 -13434
Branches 4230 2449 -1781
============================================
- Hits 18099 14159 -3940
+ Misses 19398 9677 -9721
- Partials 1001 1228 +227
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `4.61%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 53.81% -4.62%
+ Complexity 4191 4140 -51
============================================
Files 1005 1796 +791
Lines 25192 38497 +13305
Branches 2456 4240 +1784
============================================
+ Hits 14720 20719 +5999
- Misses 9190 16781 +7591
+ Partials 1282 997 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `75.00% <100.00%> (+48.68%)` | `4.00 <1.00> (+1.00)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `100.00% <100.00%> (+100.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `92.42% <100.00%> (+32.80%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/influxdb/query/BrowserLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ccm93c2VyTG9nUXVlcnkuamF2YQ==) | `2.17% <0.00%> (-58.70%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [1247 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `7.14%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.38% 50.23% -7.15%
+ Complexity 4139 3689 -450
============================================
Files 1005 999 -6
Lines 25192 25030 -162
Branches 2456 2447 -9
============================================
- Hits 14456 12575 -1881
- Misses 9487 11405 +1918
+ Partials 1249 1050 -199
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `6.68%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.51% 50.83% -6.69%
+ Complexity 4144 3710 -434
============================================
Files 1005 999 -6
Lines 25192 25030 -162
Branches 2456 2447 -9
============================================
- Hits 14490 12723 -1767
- Misses 9442 11248 +1806
+ Partials 1260 1059 -201
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810331868
@hanahmily Code style issue? Please recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.52%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.91% -0.53%
+ Complexity 4191 4139 -52
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14524 -196
- Misses 9190 9293 +103
+ Partials 1282 1263 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/influxdb/query/BrowserLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ccm93c2VyTG9nUXVlcnkuamF2YQ==) | `2.17% <0.00%> (-58.70%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `14.44%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 55.07% 40.62% -14.45%
+ Complexity 3962 2972 -990
=============================================
Files 1005 968 -37
Lines 25152 23886 -1266
Branches 2454 2322 -132
=============================================
- Hits 13852 9704 -4148
- Misses 10142 13343 +3201
+ Partials 1158 839 -319
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [269 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **decrease** coverage by `1.90%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 40.67% 38.77% -1.91%
+ Complexity 2837 2360 -477
============================================
Files 973 843 -130
Lines 24196 20985 -3211
Branches 2360 1989 -371
============================================
- Hits 9842 8136 -1706
+ Misses 13619 12267 -1352
+ Partials 735 582 -153
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/InfluxStorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0luZmx1eFN0b3JhZ2VEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [389 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `15.99%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.75% 40.76% -16.00%
+ Complexity 4092 2988 -1104
=============================================
Files 1005 968 -37
Lines 25170 23894 -1276
Branches 2455 2338 -117
=============================================
- Hits 14286 9741 -4545
- Misses 9654 13315 +3661
+ Partials 1230 838 -392
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [295 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `6.73%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 53.75% +6.73%
- Complexity 3028 4134 +1106
============================================
Files 1796 1796
Lines 38498 38500 +2
Branches 4230 4241 +11
============================================
+ Hits 18099 20694 +2595
+ Misses 19398 16811 -2587
+ Partials 1001 995 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `75.00% <100.00%> (+1.31%)` | `4.00 <1.00> (+1.00)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `92.42% <100.00%> (+1.85%)` | `11.00 <0.00> (+5.00)` | |
| [...oap/server/core/analysis/manual/searchtag/Tag.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlYXJjaHRhZy9UYWcuamF2YQ==) | `40.00% <0.00%> (-20.00%)` | `1.00% <0.00%> (ø%)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `58.53% <0.00%> (-4.88%)` | `5.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [201 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.75%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 56.52% -1.76%
+ Complexity 4177 4076 -101
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14684 14172 -512
- Misses 9234 9687 +453
+ Partials 1274 1211 -63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.80% <0.00%> (-77.31%)` | `2.00% <0.00%> (-11.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.00%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 57.28% -1.01%
+ Complexity 4177 4113 -64
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14684 14367 -317
- Misses 9234 9477 +243
+ Partials 1274 1236 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `15.61%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.75% 41.14% -15.62%
+ Complexity 4092 3018 -1074
=============================================
Files 1005 968 -37
Lines 25170 23922 -1248
Branches 2455 2343 -112
=============================================
- Hits 14286 9842 -4444
- Misses 9654 13236 +3582
+ Partials 1230 844 -386
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `7.78%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 54.79% +7.78%
- Complexity 3028 3989 +961
============================================
Files 1796 999 -797
Lines 38498 25054 -13444
Branches 4230 2448 -1782
============================================
- Hits 18099 13729 -4370
+ Misses 19398 10148 -9250
- Partials 1001 1177 +176
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1292 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **decrease** coverage by `5.24%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 40.67% 35.43% -5.25%
+ Complexity 2837 2200 -637
============================================
Files 973 843 -130
Lines 24196 20976 -3220
Branches 2360 1989 -371
============================================
- Hits 9842 7433 -2409
+ Misses 13619 13013 -606
+ Partials 735 530 -205
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [410 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **decrease** coverage by `5.11%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 40.67% 35.56% -5.12%
+ Complexity 2837 2114 -723
============================================
Files 973 812 -161
Lines 24196 20073 -4123
Branches 2360 1901 -459
============================================
- Hits 9842 7139 -2703
+ Misses 13619 12421 -1198
+ Partials 735 513 -222
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [387 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `17.42%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 53.94% 36.52% -17.43%
+ Complexity 3879 2193 -1686
=============================================
Files 1005 813 -192
Lines 25048 20164 -4884
Branches 2446 1912 -534
=============================================
- Hits 13513 7364 -6149
- Misses 10401 12248 +1847
+ Partials 1134 552 -582
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [404 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.59%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.83% -0.60%
+ Complexity 4191 4135 -56
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14505 -215
- Misses 9190 9312 +122
+ Partials 1282 1263 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `2.48%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 49.49% +2.48%
+ Complexity 3028 2988 -40
============================================
Files 1796 844 -952
Lines 38498 21201 -17297
Branches 4230 2029 -2201
============================================
- Hits 18099 10494 -7605
+ Misses 19398 9885 -9513
+ Partials 1001 822 -179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `18.41%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 54.95% 36.53% -18.42%
+ Complexity 3951 2195 -1756
=============================================
Files 1005 813 -192
Lines 25152 20165 -4987
Branches 2454 1916 -538
=============================================
- Hits 13822 7368 -6454
- Misses 10171 12246 +2075
+ Partials 1159 551 -608
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `6.29%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 46.96% +6.29%
+ Complexity 2837 2835 -2
============================================
Files 973 844 -129
Lines 24196 21195 -3001
Branches 2360 2025 -335
============================================
+ Hits 9842 9955 +113
+ Misses 13619 10477 -3142
- Partials 735 763 +28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [304 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `14.41%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 55.07% 40.65% -14.42%
+ Complexity 3962 2978 -984
=============================================
Files 1005 968 -37
Lines 25152 23894 -1258
Branches 2454 2338 -116
=============================================
- Hits 13852 9715 -4137
- Misses 10142 13340 +3198
+ Partials 1158 839 -319
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.50%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.92% -0.51%
+ Complexity 4191 4140 -51
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14527 -193
- Misses 9190 9288 +98
+ Partials 1282 1265 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/influxdb/query/BrowserLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ccm93c2VyTG9nUXVlcnkuamF2YQ==) | `2.17% <0.00%> (-58.70%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [33 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `3.34%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 50.35% +3.34%
- Complexity 3028 3039 +11
============================================
Files 1796 844 -952
Lines 38498 21201 -17297
Branches 4230 2029 -2201
============================================
- Hits 18099 10676 -7423
+ Misses 19398 9693 -9705
+ Partials 1001 832 -169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.97%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.28% 57.30% -0.98%
+ Complexity 4177 4114 -63
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14684 14373 -311
- Misses 9234 9471 +237
+ Partials 1274 1236 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `10.09%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
+ Coverage 47.01% 57.10% +10.09%
- Complexity 3028 4097 +1069
=============================================
Files 1796 999 -797
Lines 38498 25064 -13434
Branches 4230 2449 -1781
=============================================
- Hits 18099 14314 -3785
+ Misses 19398 9517 -9881
- Partials 1001 1233 +232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `0.97%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 41.64% +0.97%
+ Complexity 2837 2511 -326
============================================
Files 973 843 -130
Lines 24196 20985 -3211
Branches 2360 1989 -371
============================================
- Hits 9842 8740 -1102
+ Misses 13619 11607 -2012
+ Partials 735 638 -97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `5.29%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.71% 52.41% -5.30%
+ Complexity 4152 3806 -346
============================================
Files 1005 999 -6
Lines 25192 25052 -140
Branches 2456 2448 -8
============================================
- Hits 14540 13132 -1408
- Misses 9380 10809 +1429
+ Partials 1272 1111 -161
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [119 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `14.84%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.75% 41.91% -14.85%
+ Complexity 4092 3072 -1020
=============================================
Files 1005 968 -37
Lines 25170 23931 -1239
Branches 2455 2343 -112
=============================================
- Hits 14286 10030 -4256
- Misses 9654 13042 +3388
+ Partials 1230 859 -371
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#discussion_r603843927
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/mx/FieldsHelper.java
##########
@@ -82,7 +85,24 @@ public void init(final InputStream inputStream,
final StringBuffer serviceNamePattern = new StringBuffer();
while (m.find()) {
final String property = m.group("property");
- flatBuffersFieldNames.add(Splitter.on('.').omitEmptyStrings().splitToList(property));
+ List<String> tokens = Splitter.on('.').omitEmptyStrings().splitToList(property);
Review comment:
Just did a quick Google search, replacing the `.` with this delimiter `\.(?=([^"]*"[^"]*")*[^"]*$)` can do the trick, but you can make the call whether to replace it or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `3.02%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.26% 55.24% -3.03%
+ Complexity 4174 4002 -172
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14678 13849 -829
- Misses 9239 10035 +796
+ Partials 1275 1186 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [74 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `13.01%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.90% 43.89% -13.02%
+ Complexity 4103 3192 -911
=============================================
Files 1005 968 -37
Lines 25170 24038 -1132
Branches 2455 2351 -104
=============================================
- Hits 14323 10551 -3772
- Misses 9617 12602 +2985
+ Partials 1230 885 -345
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [228 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `14.66%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.76% 42.10% -14.67%
+ Complexity 4094 3085 -1009
=============================================
Files 1005 968 -37
Lines 25170 23931 -1239
Branches 2455 2343 -112
=============================================
- Hits 14289 10076 -4213
- Misses 9651 12994 +3343
+ Partials 1230 861 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [258 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `9.54%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.38% 47.83% -9.55%
+ Complexity 4139 3540 -599
============================================
Files 1005 999 -6
Lines 25192 25030 -162
Branches 2456 2447 -9
============================================
- Hits 14456 11974 -2482
- Misses 9487 12060 +2573
+ Partials 1249 996 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [162 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#discussion_r603870779
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/mx/FieldsHelper.java
##########
@@ -82,7 +85,24 @@ public void init(final InputStream inputStream,
final StringBuffer serviceNamePattern = new StringBuffer();
while (m.find()) {
final String property = m.group("property");
- flatBuffersFieldNames.add(Splitter.on('.').omitEmptyStrings().splitToList(property));
+ List<String> tokens = Splitter.on('.').omitEmptyStrings().splitToList(property);
Review comment:
I prefer the current way. It is more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `2.98%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.26% 55.27% -2.99%
+ Complexity 4174 4004 -170
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14678 13858 -820
- Misses 9239 10026 +787
+ Partials 1275 1186 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [73 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `6.27%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.70% 51.42% -6.28%
+ Complexity 4150 3752 -398
============================================
Files 1005 999 -6
Lines 25192 25030 -162
Branches 2456 2447 -9
============================================
- Hits 14537 12872 -1665
- Misses 9383 11095 +1712
+ Partials 1272 1063 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `5.74%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 52.75% +5.74%
- Complexity 3028 3858 +830
============================================
Files 1796 999 -797
Lines 38498 24950 -13548
Branches 4230 2440 -1790
============================================
- Hits 18099 13163 -4936
+ Misses 19398 10658 -8740
- Partials 1001 1129 +128
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1307 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.75%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.67% -0.76%
+ Complexity 4191 4129 -62
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14465 -255
- Misses 9190 9361 +171
+ Partials 1282 1254 -28
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [40 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `5.57%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.71% 52.14% -5.58%
+ Complexity 4152 3796 -356
============================================
Files 1005 999 -6
Lines 25192 25052 -140
Branches 2456 2448 -8
============================================
- Hits 14540 13063 -1477
- Misses 9380 10894 +1514
+ Partials 1272 1095 -177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [121 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `6.13%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 46.80% +6.13%
+ Complexity 2837 2830 -7
============================================
Files 973 844 -129
Lines 24196 21195 -3001
Branches 2360 2025 -335
============================================
+ Hits 9842 9921 +79
+ Misses 13619 10522 -3097
- Partials 735 752 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [305 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `3.45%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 50.46% +3.45%
- Complexity 3028 3045 +17
============================================
Files 1796 844 -952
Lines 38498 21201 -17297
Branches 4230 2029 -2201
============================================
- Hits 18099 10699 -7400
+ Misses 19398 9670 -9728
+ Partials 1001 832 -169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `2.47%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 49.48% +2.47%
+ Complexity 3028 2987 -41
============================================
Files 1796 844 -952
Lines 38498 21200 -17298
Branches 4230 2025 -2205
============================================
- Hits 18099 10491 -7608
+ Misses 19398 9885 -9513
+ Partials 1001 824 -177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `8.09%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 55.10% +8.09%
- Complexity 3028 3999 +971
============================================
Files 1796 999 -797
Lines 38498 25054 -13444
Branches 4230 2448 -1782
============================================
- Hits 18099 13807 -4292
+ Misses 19398 10052 -9346
- Partials 1001 1195 +194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.56%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.87% -0.57%
+ Complexity 4191 4136 -55
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14514 -206
- Misses 9190 9303 +113
+ Partials 1282 1263 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| [...age/plugin/jdbc/mysql/MysqlBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlzcWxCcm93c2VyTG9nUXVlcnlEQU8uamF2YQ==) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...storage/plugin/influxdb/query/BrowserLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ccm93c2VyTG9nUXVlcnkuamF2YQ==) | `2.17% <0.00%> (-58.70%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [38 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `5.69%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.70% 52.00% -5.70%
+ Complexity 4150 3791 -359
============================================
Files 1005 999 -6
Lines 25192 25052 -140
Branches 2456 2448 -8
============================================
- Hits 14537 13029 -1508
- Misses 9383 10939 +1556
+ Partials 1272 1084 -188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../provider/parser/performance/PerfDataAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9wZXJmb3JtYW5jZS9QZXJmRGF0YUFuYWx5emVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [121 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `6.42%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 53.43% +6.42%
- Complexity 3028 3901 +873
============================================
Files 1796 999 -797
Lines 38498 24950 -13548
Branches 4230 2440 -1790
============================================
- Hits 18099 13333 -4766
+ Misses 19398 10472 -8926
- Partials 1001 1145 +144
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1304 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `5.43%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 46.11% +5.43%
+ Complexity 2837 2790 -47
============================================
Files 973 844 -129
Lines 24196 21173 -3023
Branches 2360 2024 -336
============================================
- Hits 9842 9763 -79
+ Misses 13619 10679 -2940
+ Partials 735 731 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [316 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `53.81%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
+ Coverage 0.00% 53.81% +53.81%
- Complexity 0 4140 +4140
=============================================
Files 175 1796 +1621
Lines 4325 38497 +34172
Branches 485 4240 +3755
=============================================
+ Hits 0 20719 +20719
- Misses 4325 16781 +12456
- Partials 0 997 +997
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `75.00% <100.00%> (ø)` | `4.00 <1.00> (?)` | |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `92.42% <100.00%> (ø)` | `11.00 <0.00> (?)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...wser/manual/BrowserAppTrafficSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9tYW51YWwvQnJvd3NlckFwcFRyYWZmaWNTb3VyY2VEaXNwYXRjaGVyLmphdmE=) | `100.00% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (ø)` | `3.00% <0.00%> (?%)` | |
| [...metry/prometheus/httpserver/HttpServerHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvaHR0cHNlcnZlci9IdHRwU2VydmVySGFuZGxlci5qYXZh) | `61.76% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| ... and [1777 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `7.42%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 54.43% +7.42%
- Complexity 3028 3972 +944
============================================
Files 1796 999 -797
Lines 38498 25054 -13444
Branches 4230 2448 -1782
============================================
- Hits 18099 13638 -4461
+ Misses 19398 10247 -9151
- Partials 1001 1169 +168
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1294 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `3.23%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 50.25% +3.23%
- Complexity 3028 3033 +5
============================================
Files 1796 844 -952
Lines 38498 21201 -17297
Branches 4230 2029 -2201
============================================
- Hits 18099 10654 -7445
+ Misses 19398 9715 -9683
+ Partials 1001 832 -169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1340 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.87%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.43% 57.55% -0.88%
+ Complexity 4191 4126 -65
============================================
Files 1005 999 -6
Lines 25192 25080 -112
Branches 2456 2450 -6
============================================
- Hits 14720 14436 -284
- Misses 9190 9399 +209
+ Partials 1282 1245 -37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...est/BrowserErrorLogReportSingleServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRTaW5nbGVTZXJ2bGV0SGFuZGxlci5qYXZh) | `30.00% <0.00%> (-70.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...orage/plugin/jdbc/h2/dao/H2BrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-60.42%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `2.42%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 58.26% 55.83% -2.43%
+ Complexity 4174 4030 -144
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14678 13998 -680
- Misses 9239 9872 +633
+ Partials 1275 1200 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ugin/jdbc/postgresql/PostgreSQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9Qb3N0Z3JlU1FMVGFibGVJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-80.56%)` | `0.00% <0.00%> (-15.00%)` | |
| ... and [68 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `6.58%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 40.67% 47.26% +6.58%
- Complexity 2837 2845 +8
============================================
Files 973 844 -129
Lines 24196 21195 -3001
Branches 2360 2025 -335
============================================
+ Hits 9842 10017 +175
+ Misses 13619 10405 -3214
- Partials 735 773 +38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-93.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `10.13%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
+ Coverage 47.01% 57.14% +10.13%
- Complexity 3028 4099 +1071
=============================================
Files 1796 999 -797
Lines 38498 25064 -13434
Branches 4230 2449 -1781
=============================================
- Hits 18099 14323 -3776
+ Misses 19398 9508 -9890
- Partials 1001 1233 +232
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `4.02%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 51.03% +4.02%
- Complexity 3028 3085 +57
============================================
Files 1796 844 -952
Lines 38498 21229 -17269
Branches 4230 2034 -2196
============================================
- Hits 18099 10835 -7264
+ Misses 19398 9555 -9843
+ Partials 1001 839 -162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1338 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `3.71%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.71% 54.00% -3.72%
+ Complexity 4152 3933 -219
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14540 13538 -1002
- Misses 9380 10362 +982
+ Partials 1272 1170 -102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `3.56%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 50.57% +3.56%
- Complexity 3028 3054 +26
============================================
Files 1796 844 -952
Lines 38498 21201 -17297
Branches 4230 2029 -2201
============================================
- Hits 18099 10723 -7376
+ Misses 19398 9646 -9752
+ Partials 1001 832 -169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1340 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `10.84%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
+ Coverage 47.01% 57.85% +10.84%
- Complexity 3028 4134 +1106
=============================================
Files 1796 999 -797
Lines 38498 25064 -13434
Branches 4230 2449 -1781
=============================================
- Hits 18099 14501 -3598
+ Misses 19398 9316 -10082
- Partials 1001 1247 +246
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| [...ywalking/oap/server/library/util/ConnectUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvQ29ubmVjdFV0aWxzLmphdmE=) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `8.77%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.38% 48.60% -8.78%
+ Complexity 4139 3469 -670
============================================
Files 1005 968 -37
Lines 25192 24127 -1065
Branches 2456 2359 -97
============================================
- Hits 14456 11728 -2728
- Misses 9487 11421 +1934
+ Partials 1249 978 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `3.70%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
- Coverage 57.71% 54.01% -3.71%
+ Complexity 4152 3935 -217
============================================
Files 1005 999 -6
Lines 25192 25070 -122
Branches 2456 2449 -7
============================================
- Hits 14540 13541 -999
- Misses 9380 10359 +979
+ Partials 1272 1170 -102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (0c90b7f) into [master](https://codecov.io/gh/apache/skywalking/commit/9a3e8357cc2a7f700232efdd93914d971432cc45?el=desc) (9a3e835) will **increase** coverage by `7.65%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 0c90b7f differs from pull request most recent head f157887. Consider uploading reports for the commit f157887 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
============================================
+ Coverage 47.01% 54.66% +7.65%
- Complexity 3028 3986 +958
============================================
Files 1796 999 -797
Lines 38498 25054 -13444
Branches 4230 2448 -1782
============================================
- Hits 18099 13697 -4402
+ Misses 19398 10188 -9210
- Partials 1001 1169 +168
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (-43.69%)` | `4.00 <1.00> (+1.00)` | :arrow_down: |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (-22.88%)` | `11.00 <0.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (-92.86%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1292 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [9a3e835...f157887](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6654: Resolve envoy service name from a different position
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6654:
URL: https://github.com/apache/skywalking/pull/6654#issuecomment-810510341
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=h1) Report
> Merging [#6654](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=desc) (7dc1ee1) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `13.96%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 7dc1ee1 differs from pull request most recent head 4f7a8db. Consider uploading reports for the commit 4f7a8db to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6654 +/- ##
=============================================
- Coverage 56.76% 42.80% -13.97%
+ Complexity 4094 3121 -973
=============================================
Files 1005 968 -37
Lines 25170 23934 -1236
Branches 2455 2343 -112
=============================================
- Hits 14289 10246 -4043
- Misses 9651 12827 +3176
+ Partials 1230 861 -369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `30.00% <100.00%> (+3.68%)` | `4.00 <1.00> (+1.00)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `67.69% <100.00%> (+8.07%)` | `11.00 <0.00> (+5.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [242 more](https://codecov.io/gh/apache/skywalking/pull/6654/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=footer). Last update [523944a...4f7a8db](https://codecov.io/gh/apache/skywalking/pull/6654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org