You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Ashvin A <aa...@gmail.com> on 2015/09/11 23:42:37 UTC
Review Request 38320: Search Function ResultCollector

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38320/
-----------------------------------------------------------

Review request for geode and Dan Smith.


Repository: geode


Description
-------

Add a test to verify error handling during reduce phase in a function.

GEODE-11: Register LuceneQueryFunction on members

LuceneQueryFunction will be registered by LuceneQueryService. If the service is
running, the member is capable of executing search function.

GEODE-11: Refactor CollectorManager interface

CollectorManager creates new collectors and merges results of the collectors.
Earlier the merge result type could be different from the collector type.
CollectorManager could actually use a collector itself to merge the results.
That way the actions on members and search coordinator will be the same.

GEODE-11: Add search function ResultCollector


Diffs
-----

  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java 864de33cf5175093db537c6f9679b3d574bb7d7f 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/CollectorManager.java 8039d1415782b506df2b54e939bde6a0907eaf27 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneQueryFunction.java 27a42adc98bcad29d47921a540ea803fab80df05 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneSearchFunctionArgs.java 2a5a5b61eafac588e8af3c9da5bddf1afb8d580c 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollector.java 6b02391909a17af7d4efe9e3a2c6e1725c53bb99 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollectorManager.java 7360c3c8f9e0076072ed7b246b1803cb3e948383 
  gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java PRE-CREATION 
  gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java PRE-CREATION 
  gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java 4c350cfb4dd18aec7587b67ed01daf29c761647e 
  gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollectorJUnitTest.java 47662203738811a0a4a7f6a9cc976588fac7d397 
  gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/38320/diff/


Testing
-------


Thanks,

Ashvin A