You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 23:01:55 UTC
[GitHub] [arrow] seddonm1 opened a new pull request #9074: ARROW-11102: [Rust][DataFusion] fmt::Debug for ScalarValue(Utf8) is always quoted
seddonm1 opened a new pull request #9074:
URL: https://github.com/apache/arrow/pull/9074
This PR changes the `fmt::Debug` implementation for `ScalarValue(Utf8)` and `ScalarValue(LargeUtf8)` so that it is possible to differentiate `Utf8("NULL")` and `Utf8(NULL)` when viewing execution plans (as the string "NULL" may be a valid value).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9074: ARROW-11102: [Rust][DataFusion] fmt::Debug for ScalarValue(Utf8) is always quoted
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9074:
URL: https://github.com/apache/arrow/pull/9074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9074: ARROW-11102: [Rust][DataFusion] fmt::Debug for ScalarValue(Utf8) is always quoted
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9074:
URL: https://github.com/apache/arrow/pull/9074#issuecomment-753402675
https://issues.apache.org/jira/browse/ARROW-11102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9074: ARROW-11102: [Rust][DataFusion] fmt::Debug for ScalarValue(Utf8) is always quoted
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9074:
URL: https://github.com/apache/arrow/pull/9074#issuecomment-753402864
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=h1) Report
> Merging [#9074](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=desc) (40ef020) into [master](https://codecov.io/gh/apache/arrow/commit/cd22be6efedbf9832b5ea875ca59bb42de7b6c28?el=desc) (cd22be6) will **decrease** coverage by `0.00%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9074 +/- ##
==========================================
- Coverage 82.55% 82.55% -0.01%
==========================================
Files 203 203
Lines 50043 50045 +2
==========================================
Hits 41315 41315
- Misses 8728 8730 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9074/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `58.99% <50.00%> (-0.08%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9074/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=footer). Last update [cd22be6...40ef020](https://codecov.io/gh/apache/arrow/pull/9074?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org