You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mi...@apache.org on 2016/07/19 07:32:57 UTC
zeppelin git commit: [ZEPPELIN-1109] Remove bootstrap dialog
fade-in/out animation
Repository: zeppelin
Updated Branches:
refs/heads/master 4e6c7990c -> fea00460b
[ZEPPELIN-1109] Remove bootstrap dialog fade-in/out animation
### What is this PR for?
This PR will fix [ZEPPELIN-1109](https://issues.apache.org/jira/browse/ZEPPELIN-1109).
I'm not sure this approach can be the best way for fixing this issue since I would prefer to have the fade-in/out animation for bootstrap dialog. So if anyone has better idea for this, please let me know.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-1109](https://issues.apache.org/jira/browse/ZEPPELIN-1109)
### How should this be tested?
1. Press `Enter` button right after clicking any bootstrap dialog (i.e. trash can icon in the notebook)
-> Bootstrap dialog will be shown up multiple times
2. Apply this patch and [build `zeppelin-web`](https://github.com/apache/zeppelin/tree/master/zeppelin-web#configured-environment)
3. Try number 1 again -> you can see there is no fade animation so you don't have time interval to generate multi dialogs
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fb...@hanmail.net>
Closes #1179 from AhyoungRyu/ZEPPELIN-1109 and squashes the following commits:
668fde0 [AhyoungRyu] Fix jscs checkstyle error
77c94ee [AhyoungRyu] Remove bootstrap dialog animation by default
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/fea00460
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/fea00460
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/fea00460
Branch: refs/heads/master
Commit: fea00460bd8a286dfb18ebd1fe2b6639d5cc8b84
Parents: 4e6c799
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Thu Jul 14 10:36:59 2016 +0900
Committer: Mina Lee <mi...@apache.org>
Committed: Tue Jul 19 16:32:53 2016 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/app.controller.js | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/fea00460/zeppelin-web/src/app/app.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/app.controller.js b/zeppelin-web/src/app/app.controller.js
index ce466a7..8a0466b 100644
--- a/zeppelin-web/src/app/app.controller.js
+++ b/zeppelin-web/src/app/app.controller.js
@@ -44,4 +44,7 @@ angular.module('zeppelinWebApp').controller('MainCtrl', function($scope, $rootSc
BootstrapDialog.defaultOptions.onshown = function() {
angular.element('#' + this.id).find('.btn:last').focus();
};
+
+ // Remove BootstrapDialog animation
+ BootstrapDialog.configDefaultOptions({animate: false});
});