You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/21 16:04:48 UTC

[GitHub] [nifi] dan-s1 opened a new pull request, #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

dan-s1 opened a new pull request, #6689:
URL: https://github.com/apache/nifi/pull/6689

   …function.
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on code in PR #6689:
URL: https://github.com/apache/nifi/pull/6689#discussion_r1060723358


##########
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class GetUriEvaluator extends StringEvaluator {
+
+    private final List<Evaluator<String>> uriArgs;
+
+    public GetUriEvaluator(List<Evaluator<String>> uriArgs) {
+        this.uriArgs = uriArgs;
+    }
+
+    @Override
+    public QueryResult<String> evaluate(EvaluationContext evaluationContext) {
+        List<String> args = uriArgs.stream()
+                .map(uriArg -> uriArg.evaluate(evaluationContext).getValue())
+                .collect(Collectors.toList());
+
+        try {
+            if (args.size() == 7) {
+                return new StringQueryResult(new URI(args.get(0), args.get(1), args.get(2),
+                        Integer.parseInt(args.get(3)), args.get(4), args.get(5), args.get(6)).toString());

Review Comment:
   @exceptionfactory Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322669243

   @exceptionfactory If you have time, can you please review this in order for this to get into 1.19?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1370134527

   @exceptionfactory I noticed the build ci-workflow / Ubuntu Zulu JDK 11 HI failed but it failed on a unit test unrelated to my changes. Also the ci-workflow / Ubuntu Zulu JDK 17 EN timed out. Please advise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364267630

   Thanks for the reply @dan-s1.
   
   As you observed, the Expression Language parser does not support a literal `null` as a function argument. It would take a bit more work, but it seems worth evaluating what it would take to support a literal `null` argument for `getUri`. It seems like it could be scoped to this function.
   
   For `getUri` itself, there does not seem to be much value in the three-argument non-hierarchical option for `mailto` and similar links. This could be added later, but I think it makes more sense to focus on the hierarchical URI constructors unless you have a specific use case in mind for non-hierarchical URIs.
   
   For hierarchical URIs, the four and five argument constructors appear to fall into the convenience category. For simplicity of the initial implementation, what do you think of limiting the implementation to the seven argument constructor? Although it is the most verbose, it provides the clearest implementation for documentation and usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1366789116

   @exceptionfactory I added the null literal as you requested and modified the documentation to reflect this. Please let me know if my changes are what you were intending. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1330825220

   @exceptionfactory Now that 1.19.0 has been released, when you have some time can you please review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1370171923

   The latest PR build appears to be working as expected, it sounds like the other issues were unrelated intermittent failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory closed pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …
URL: https://github.com/apache/nifi/pull/6689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6689:
URL: https://github.com/apache/nifi/pull/6689#discussion_r1056009178


##########
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class GetUriEvaluator extends StringEvaluator {
+
+    private final Evaluator<String>[] uriArgs;
+
+    public GetUriEvaluator(Evaluator<String>[] uriArgs) {
+        this.uriArgs = uriArgs;
+    }
+
+    @Override
+    public QueryResult<String> evaluate(EvaluationContext evaluationContext) {
+        List<String> args = Arrays.stream(uriArgs)
+                .map(uriArg -> uriArg.evaluate(evaluationContext).getValue())
+                .map(string -> StringUtils.isBlank(string) ? null : string)

Review Comment:
   The `StringUtils.isBlank()` check would convert both empty strings such as `""` as well as strings with spaces such as `"  "` to `null`. Although these seem to be unlikely arguments, it raises a larger question about passing empty arguments. The check should probably be simplified to check for an empty string:
   ```suggestion
                   .map(string -> string == null || string.isEmpty() ? null : string)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364408883

   > What did you have in mind for implementing a literal null as a function argument? I only question if it is more clearer than specifying to users to use an empty string which we can convert to null on the back end.
   
   I was thinking that `null` would be handled as a literal along the following lines:
   
   ```
   ${getUri('https', null, 'nifi.apache.org', 8443, '/docs.html', null, null)}
   ```
   
   An empty string could be passed to any of the string arguments, but it allowing a `null` would avoid the need to convert the arguments and clarify expected behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1372398279

   @exceptionfactory Is there anything else that needs to be done for this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363956081

   > Thanks for working on this new feature @dan-s1. Although most of the implementation makes sense, it raises some questions about treating blanks strings as nulls. Although the `java.net.URI` has a number of constructors, it seems like this may provide more options than necessary. There is some value in simplicity, versus exposing all the possible options, which could also avoid potential confusion related to handling blank strings as nulls.
   > 
   > The discussion on NIFI-10754 originated out of issues with the `urlEncode` function. If the implementation were to be scoped down to just something like `uriEncodePath`, for instance, would that provide the desired functionality?
   
   @exceptionfactory  If I understand you correctly that means there would have to be potentially two calls when constructing a URI, one to urlEncodePath and one to urlEncode to encode the parameters. I was actually intending to simplify that process of URI construction with one call which would take care of the encoding for both the path and the parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364180293

   > Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense.
   > 
   > With that background, do you need all of the possible constructor options? It might be simpler to support just one or two options, as opposed to all of the convenience constructors.
   > 
   That is a hard call because I am not sure what different people need.
   
   > To the other question, is there a possibility that an empty string should be allowed as an argument instead of treated as `null`? That kind of implicit conversion to `null` seems like it could create confusion, and might actually be a reason to provide a different set of supported arguments so that particular values can be `null` when passed to the `URI` constructors.
   Per the URI javadocs
   
   > a component of the new URI may be left undefined by passing null for the corresponding parameter.
   I did not see a way of explicitly passing null except if a blank string was passed. Please let me know otherwise if null can be passed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364167903

   Thanks for clarifying the intent @dan-s1, constructing the complete URI in a single function makes sense.
   
   With that background, do you need all of the possible constructor options? It might be simpler to support just one or two options, as opposed to all of the convenience constructors.
   
   To the other question, is there a possibility that an empty string should be allowed as an argument instead of treated as `null`? That kind of implicit conversion to `null` seems like it could create confusion, and might actually be a reason to provide a different set of supported arguments so that particular values can be `null` when passed to the `URI` constructors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6689:
URL: https://github.com/apache/nifi/pull/6689#discussion_r1059523853


##########
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GetUriEvaluator.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class GetUriEvaluator extends StringEvaluator {
+
+    private final List<Evaluator<String>> uriArgs;
+
+    public GetUriEvaluator(List<Evaluator<String>> uriArgs) {
+        this.uriArgs = uriArgs;
+    }
+
+    @Override
+    public QueryResult<String> evaluate(EvaluationContext evaluationContext) {
+        List<String> args = uriArgs.stream()
+                .map(uriArg -> uriArg.evaluate(evaluationContext).getValue())
+                .collect(Collectors.toList());
+
+        try {
+            if (args.size() == 7) {
+                return new StringQueryResult(new URI(args.get(0), args.get(1), args.get(2),
+                        Integer.parseInt(args.get(3)), args.get(4), args.get(5), args.get(6)).toString());

Review Comment:
   Recommend breaking this into multiple lines for readability. I also recommend moving the integer parsing to a separate private method, where the `NumberFormatException` could be caught apart from the others.
   ```suggestion
                   final String scheme = args.get(0);
                   final String userInfo = args.get(1);
                   final String host = args.get(2);
                   final int port = getPort(args.get(3));
                   final String path = args.get(4);
                   final String query = args.get(5);
                   final String fragment = args.get(6);
                   final URI uri = new URI(scheme, userInfo, host, port, path, query, fragment);
                   return new StringQueryResult(uri.toString());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364270877

   @exceptionfactory I am fine with only implementing the the seven argument constructor. What did you have in mind for implementing a literal null as a function argument? I only question if it is more clearer than specifying to users to use an empty string which we can convert to null on the back end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363125181

   @exceptionfactory Wondering if this could be revisited. It is functionality my team could use. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #6689: [NIFI-10754] Initial check in of new getUri NIFI Expression Language …

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322758227

   Thanks the contribution @dan-s1, the general approach makes sense on a cursory review, but I would like to take a closer look, so I don't think this will make it in to 1.19.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org