You are viewing a plain text version of this content. The canonical link for it is here.
Posted to discuss-archive@tvm.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2026/01/03 05:20:51 UTC
[PR] [Relax] Move GetUsedVars to analysis module [tvm]
guan404ming opened a new pull request, #18632:
URL: https://github.com/apache/tvm/pull/18632
## Why
The GetUsedVars function was defined locally in binding_rewrite.cc with a TODO comment suggesting it should be moved to the analysis module. This refactoring improves code organization by placing the utility function alongside other variable analysis functions.
## How
- Move GetUsedVars implementation to analysis module
- Add FFI registration and Python wrapper
- Add parametrized test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h merged PR #18632:
URL: https://github.com/apache/tvm/pull/18632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "tlopex (via GitHub)" <gi...@apache.org>.
tlopex commented on code in PR #18632:
URL: https://github.com/apache/tvm/pull/18632#discussion_r2658945940
##########
python/tvm/relax/analysis/analysis.py:
##########
@@ -312,6 +312,26 @@ def all_vars(expr: Expr) -> List[Var]:
return _ffi_api.all_vars(expr)
+def get_used_vars(expr: Expr) -> List[Var]:
Review Comment:
I agree @guan404ming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #18632:
URL: https://github.com/apache/tvm/pull/18632#discussion_r2659788506
##########
python/tvm/relax/analysis/analysis.py:
##########
@@ -312,6 +312,26 @@ def all_vars(expr: Expr) -> List[Var]:
return _ffi_api.all_vars(expr)
+def get_used_vars(expr: Expr) -> List[Var]:
Review Comment:
Sure, I've updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h commented on code in PR #18632:
URL: https://github.com/apache/tvm/pull/18632#discussion_r2658921061
##########
python/tvm/relax/analysis/analysis.py:
##########
@@ -312,6 +312,26 @@ def all_vars(expr: Expr) -> List[Var]:
return _ffi_api.all_vars(expr)
+def get_used_vars(expr: Expr) -> List[Var]:
Review Comment:
nit: the func name might be better to be `used_vars()` to be consistent with `all_vars()` and `free_vars()`? cc @tlopex @cbalint13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #18632:
URL: https://github.com/apache/tvm/pull/18632#issuecomment-3707005028
cc @mshr-h @tlopex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #18632:
URL: https://github.com/apache/tvm/pull/18632#issuecomment-3708908728
Thanks for all reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #18632:
URL: https://github.com/apache/tvm/pull/18632#issuecomment-3706775089
## Summary of Changes
Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly improves code organization by refactoring the `GetUsedVars` utility. By relocating it to the dedicated `analysis` module, the function is now centralized with other variable analysis tools, enhancing modularity and maintainability. The change also extends its utility by providing FFI registration and a Python API, ensuring broader accessibility and easier integration into various workflows, all while being backed by new comprehensive tests.
### Highlights
* **Function Relocation**: The `GetUsedVars` function has been moved from `src/relax/ir/binding_rewrite.cc` to the `analysis` module, specifically implemented in `src/relax/analysis/udchain.cc` and declared in `include/tvm/relax/analysis.h`.
* **FFI and Python API Exposure**: The `GetUsedVars` function is now registered for FFI (Foreign Function Interface) in C++ and exposed through a new Python wrapper `get_used_vars` in `python/tvm/relax/analysis/analysis.py`, making it accessible from Python.
* **New Test Coverage**: A new parametrized test `test_get_used_vars` has been added to `tests/python/relax/test_analysis.py` to validate the functionality of the moved and exposed `get_used_vars` function.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org
Re: [PR] [Relax] Move GetUsedVars to analysis module [tvm]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #18632:
URL: https://github.com/apache/tvm/pull/18632#discussion_r2658730704
##########
src/relax/analysis/udchain.cc:
##########
@@ -121,10 +121,29 @@ ffi::Map<Var, ffi::Array<Var>> DataflowBlockUseDef(const DataflowBlock& dfb) {
TVM_FFI_STATIC_INIT_BLOCK() {
namespace refl = tvm::ffi::reflection;
- refl::GlobalDef().def("relax.analysis.udchain", DataflowBlockUseDef);
+ refl::GlobalDef()
+ .def("relax.analysis.udchain", DataflowBlockUseDef)
+ .def("relax.analysis.get_used_vars", [](const Expr& expr) {
+ auto used_vars = GetUsedVars(expr);
+ ffi::Array<Var> result;
+ for (const VarNode* var_node : used_vars) {
+ result.push_back(ffi::GetRef<Var>(var_node));
+ }
+ return result;
Review Comment:

For improved performance, especially when `used_vars` is large, consider building a `std::vector` with pre-reserved capacity and then constructing the `ffi::Array` from it. This avoids potential reallocations that can occur with repeated `push_back` calls on `ffi::Array`.
```c
std::vector<Var> result_vec;
result_vec.reserve(used_vars.size());
for (const VarNode* var_node : used_vars) {
result_vec.push_back(ffi::GetRef<Var>(var_node));
}
return ffi::Array<Var>(std::move(result_vec));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org