[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1284: refactor(idl): unify the *.thrift files used by cpp and go-client

[GitBox <gi...@apache.org>]

acelyc111 commented on PR #1284:
URL: https://github.com/apache/incubator-pegasus/pull/1284#issuecomment-1341954730

   > I did intentionally name the thrift structs to be different with rDSN. Because the names in go-client are much shorter, clearer than the rDSN ones, aren't they? 🤣 But certainly, you can rollback to the naming style that is aligned with the core project. I have no opinion with that. Or if possible, I suggest that you can rename all ConfigurationXXXResponse to XXXResponse and I think it would make more senses.
   
   I agree, really the go-client side are more tidy. I'm planning to unify all server side and all client sides in following patches at first, and then refactor to a better naming, of course, make sure there is no compatiblity issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org