You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Raphael Taylor-Davies <r....@googlemail.com.INVALID> on 2023/11/06 12:23:47 UTC

[RESULT][VOTE][RUST] Release Apache Arrow Rust Object Store 0.8.0 RC1

With 3 +1 votes (3 binding) the release is approved

The release is available here: 
https://dist.apache.org/repos/dist/release/arrow/arrow-object-store-rs-0.8.0 


It has also been released to crates.io.

Thank you to everyone who helped verify this release

On 03/11/2023 15:44, Andrew Lamb wrote:
> +1
>
> I likewise commented out the -e in the verification script, and have
> reviewed the test fix as well as reviewed the output (on mac x86).
> Everthing looks good to me.
>
> Thank you Raphael,
> Andrew
>
>
> On Thu, Nov 2, 2023 at 5:29 PM L. C. Hsieh <vi...@gmail.com> wrote:
>
>> Tried the verification script after set -e removed.
>>
>> Got:
>>
>> failures:
>>      local::tests::invalid_path
>>
>> test result: FAILED. 55 passed; 1 failed; 1 ignored; 0 measured; 0
>> filtered out; finished in 4.26s
>>
>> After that, cargo publish --dry-run continued to be run without
>> manually and got:
>>
>> + TEST_SUCCESS=yes
>> + echo 'Release candidate looks good!'
>> Release candidate looks good!
>>
>> So it looks good then.
>>
>> +1 if test issues can be ignored.
>>
>> On Thu, Nov 2, 2023 at 1:31 PM Raphael Taylor-Davies
>> <r....@googlemail.com.invalid> wrote:
>>> Aah, because the release script bails out on the first error? You could
>>> either:
>>>
>>> - Remove set -e from the top of the script to have it continue on error
>>> - Run the remaining check of `cargo publish --dry-run` manually
>>>
>>> I can cut another RC tomorrow if neither of these is a satisfactory
>>> solution, I just felt there was prior precedent for not holding releases
>>> back on test issues.
>>>
>>> On 02/11/2023 20:07, L. C. Hsieh wrote:
>>>> Hmm, I think we cannot run the verification script unless the issue is
>> fixed?
>>>> On Thu, Nov 2, 2023 at 6:40 AM Raphael Taylor-Davies
>>>> <r....@googlemail.com.invalid> wrote:
>>>>> Aah, that was a mistake introduced in a test in [1], where it was
>>>>> incorrectly relying on a particular ordering when listing a directory.
>>>>> I've created a PR that should fix the issue [2].
>>>>>
>>>>> As this is purely a testing oversight, I am not sure this warrants
>>>>> cutting another RC unless you feel otherwise?
>>>>>
>>>>> [1]:
>>>>>
>> https://github.com/apache/arrow-rs/pull/5020/files#diff-e0de0bcc9edd75e6cb6bb15dda180797a0c809b1e01b23cc2189f76409a1c2f5R1426
>>>>> [2]: https://github.com/apache/arrow-rs/pull/5026
>>>>>
>>>>> On 02/11/2023 13:31, Andrew Lamb wrote:
>>>>>> When I ran the verification script (on mac x86-46) it failed one of
>> the
>>>>>> tests:
>>>>>>
>>>>>> ```
>>>>>> ---- local::tests::invalid_path stdout ----
>>>>>> thread 'local::tests::invalid_path' panicked at src/local.rs:1389:9:
>>>>>> assertion `left == right` failed
>>>>>>      left: [Path { raw: "directory/child.txt" }, Path { raw: "💀" }]
>>>>>>     right: [Path { raw: "💀" }, Path { raw: "directory/child.txt" }]
>>>>>> note: run with `RUST_BACKTRACE=1` environment variable to display a
>>>>>> backtrace
>>>>>>
>>>>>>
>>>>>> failures:
>>>>>>        local::tests::invalid_path
>>>>>> ```
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Nov 2, 2023 at 7:48 AM Raphael Taylor-Davies
>>>>>> <r....@googlemail.com.invalid> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I would like to propose a release of Apache Arrow Rust Object
>>>>>>> Store Implementation, version 0.8.0.
>>>>>>>
>>>>>>> This release candidate is based on commit:
>>>>>>> ad211fe324d259bf9fea1c43a3a82b3c833f6d7a [1]
>>>>>>>
>>>>>>> The proposed release tarball and signatures are hosted at [2].
>>>>>>>
>>>>>>> The changelog is located at [3].
>>>>>>>
>>>>>>> Please download, verify checksums and signatures, run the unit
>> tests,
>>>>>>> and vote on the release. There is a script [4] that automates some
>> of
>>>>>>> the verification.
>>>>>>>
>>>>>>> !! Please note you will need to use the latest version of the
>>>>>>> verification scripts on master !!
>>>>>>>
>>>>>>> This is the result of a doctest issue when compiling with only the
>>>>>>> default features [5]
>>>>>>>
>>>>>>> The vote will be open for at least 72 hours.
>>>>>>>
>>>>>>> [ ] +1 Release this as Apache Arrow Rust Object Store
>>>>>>> [ ] +0
>>>>>>> [ ] -1 Do not release this as Apache Arrow Rust Object Store
>> because...
>>>>>>> [1]:
>>>>>>>
>>>>>>>
>> https://github.com/apache/arrow-rs/tree/ad211fe324d259bf9fea1c43a3a82b3c833f6d7a
>>>>>>> [2]:
>>>>>>>
>>>>>>>
>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-object-store-rs-0.8.0-rc1
>>>>>>> [3]:
>>>>>>>
>>>>>>>
>> https://github.com/apache/arrow-rs/blob/ad211fe324d259bf9fea1c43a3a82b3c833f6d7a/object_store/CHANGELOG.md
>>>>>>> [4]:
>>>>>>>
>>>>>>>
>> https://github.com/apache/arrow-rs/blob/master/object_store/dev/release/verify-release-candidate.sh
>>>>>>> [5]: https://github.com/apache/arrow-rs/issues/5025
>>>>>>>
>>>>>>>