Re: [PR] KAFKA-17727: swallow exceptions on segment flush [kafka]

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #17425:
URL: https://github.com/apache/kafka/pull/17425#issuecomment-2458020662

   Have we considered the other alternative of making `flush()` in `Indices` and `FileRecords` check for existence?
   
   This alternative has the advantages of:
   1. We are not hiding exceptions which could be genuinely caused by bugs?
   2. We are following the same paradigm as we take for deletion of these entities e.g. see `FileRecords.deleteIfExists`
   3. We are future-proofing scenarios where the flush on an index may be called from a different place in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org