[GitHub] [ozone] rakeshadr commented on a change in pull request #2836: HDDS-5981. Refactor usage of bucket type.

[GitBox <gi...@apache.org>]

rakeshadr commented on a change in pull request #2836:
URL: https://github.com/apache/ozone/pull/2836#discussion_r748700761



##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneFSUtils.java
##########
@@ -210,7 +210,7 @@ public static int getFileCount(String keyName) {
 
 
   public static boolean isFSOptimizedBucket(BucketLayout bucketLayout) {

Review comment:
       Thank you @mukul1987 for the patch. Nice refactoring!
   
   Can you please remove the OzoneFSUtils#isFSOptimizedBucket() method and all the callers can directly use `bucketLayout.isFileSystemOptimized()`.
   
   OzoneFSUtils#isFSOptimizedBucket() method used in following functions.
   ```
   BasicRootedOzoneFileSystem.rename(Path, Path) 
   TrashOzoneFileSystem.rename(Path, Path)  
   BasicRootedOzoneFileSystem.delete(Path, boolean) 
   TrashOzoneFileSystem.delete(Path, boolean) 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org