[jira] [Commented] (FLUME-2897) AsyncHBase sink NPE when Channel.getTransaction() fails

["Mike Percy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215006#comment-15215006 ] 

Mike Percy commented on FLUME-2897:
-----------------------------------

The reason this patch is correct is because it would be incorrect to call txn.close() in the finally block if txn is null. Same goes for what we're doing in the catch block: txn.rollback(). This is the correct idiom.

> AsyncHBase sink NPE when Channel.getTransaction() fails
> -------------------------------------------------------
>
>                 Key: FLUME-2897
>                 URL: https://issues.apache.org/jira/browse/FLUME-2897
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.6.0
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>         Attachments: FLUME-2897-1.patch
>
>
> There is a possibility for a NPE in the AsyncHBaseSink when a channel getTransaction() call fails. This is possible when the FileChannel is out of disk space.
> Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)