[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400643075
 
 

 ##########
 File path: lua/apisix/plugins/limit-count.lua
 ##########
 @@ -82,6 +88,8 @@ function _M.check_schema(conf)
 
         conf.redis_port = conf.redis_port or 6379
         conf.redis_timeout = conf.redis_timeout or 1000
+        conf.redis_pool_size = conf.redis_pool_size or 1000
+        conf.redis_backlog = conf.redis_backlog or 1000
 
 Review comment:
   Please set the backlog to `nil` to disable the feature by default.
   Two reasons:
   1. the backlog feature in cosocket is considered experimental.
   2. it isn't a smart idea to queue limitation count. This will be make the result incorrect. The operation should be finished ASAP to make the limitation up to date.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services