You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "mihaibudiu (via GitHub)" <gi...@apache.org> on 2025/10/13 21:11:52 UTC
[PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
mihaibudiu opened a new pull request, #4579:
URL: https://github.com/apache/calcite/pull/4579
…IndexOutOfBoudsException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4579:
URL: https://github.com/apache/calcite/pull/4579#issuecomment-3399156916
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4579) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4579&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4579&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4579&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4579&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4579&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4579)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427538933
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
That name would suggest that the values of the row fields are unequal, and not their count.
Maybe unequalRowSizes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427545035
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
Should the description in the code be updated as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4579:
URL: https://github.com/apache/calcite/pull/4579#issuecomment-3399533878
I have squashed the commits and I will merge when CI passes; thank you @xiedeyantu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427588581
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
I think you have asked the exact same question above.
I will change it to `unequalRowSizes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427598329
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
"entries" are the fields of the row.
"size" is the count of the "entries" collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427580657
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
I think this is fine. Moreover, this is the exact error message that Postgres provides as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427562171
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
which one is the "description in the code"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4579:
URL: https://github.com/apache/calcite/pull/4579#issuecomment-3399586988
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4579) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4579&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4579&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4579&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4579&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4579&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4579)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427583660
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
Isn't the name "unequalRowEntries" more appropriate for this error description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427526018
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
Would `unequalRowEntries` be a better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #4579:
URL: https://github.com/apache/calcite/pull/4579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427596592
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
Yes, I understand that "unequalRowEntries" might be more fitting than "unequalRowSizes" for your error description. Perhaps I didn't fully grasp the exact meaning between "Entries" and "Sizes" — you likely have more expertise in this. This is a minor detail, and I'm fine with either option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7225] Comparing ROW values with different lengths causes an … [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4579:
URL: https://github.com/apache/calcite/pull/4579#discussion_r2427579194
##########
core/src/main/java/org/apache/calcite/runtime/CalciteResource.java:
##########
@@ -1157,6 +1157,9 @@ ExInst<RuntimeException> multipleCapturingGroupsForRegexpFunctions(String value,
@BaseMessage("Index in ROW type does not have a constant integer or string value")
ExInst<SqlValidatorException> illegalRowIndex();
+ @BaseMessage("Unequal number of entries in ROW expressions")
+ ExInst<SqlValidatorException> unequalRows();
Review Comment:
This description `BaseMessage("Unequal number of entries in ROW expressions")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org