You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 14:59:37 UTC
[GitHub] [pulsar] lhotari opened a new pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
lhotari opened a new pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278
### Motivation
The jacoco-maven-plugin integration with the build is broken
### Modifications
- Fix the integration by replacing `<argLine>` with `<argLine>@{argLine} ` in `maven-surefire-plugin` configuration
- Upgrade jacoco-maven-plugin to latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1040021842
@lhotari I cannot run the unit test in IDEA since the PR into master branch:
```
Error: could not open `{testJacocoAgentArgument}'
```
Do you have any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 edited a comment on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 edited a comment on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
@lhotari
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 removed a comment on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 removed a comment on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
@lhotari
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#discussion_r806013731
##########
File path: buildtools/pom.xml
##########
@@ -170,7 +170,7 @@
<value>org.apache.pulsar.tests.PulsarTestListener,org.apache.pulsar.tests.AnnotationListener,org.apache.pulsar.tests.FailFastNotifier</value>
</property>
</properties>
- <argLine>
+ <argLine>@{argLine}
Review comment:
thanks, I set `propertyName` to `testJacocoAgentArgument`. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
nodece commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1040021842
@lhotari I cannot run the unit test in IDEA since the PR into master branch:
```
Error: could not open `{testJacocoAgentArgument}'
```
Do you have any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#discussion_r805971584
##########
File path: buildtools/pom.xml
##########
@@ -170,7 +170,7 @@
<value>org.apache.pulsar.tests.PulsarTestListener,org.apache.pulsar.tests.AnnotationListener,org.apache.pulsar.tests.FailFastNotifier</value>
</property>
</properties>
- <argLine>
+ <argLine>@{argLine}
Review comment:
what about using a custom variable name ? argLine is a bit generic
something like
```
<configuration>
<propertyName>jacoco-surefire-args</propertyName>
</configuration>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 edited a comment on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 edited a comment on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
@lhotari
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#discussion_r806013731
##########
File path: buildtools/pom.xml
##########
@@ -170,7 +170,7 @@
<value>org.apache.pulsar.tests.PulsarTestListener,org.apache.pulsar.tests.AnnotationListener,org.apache.pulsar.tests.FailFastNotifier</value>
</property>
</properties>
- <argLine>
+ <argLine>@{argLine}
Review comment:
thanks, I set `propertyName` to `testJacocoAgentArgument`. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 removed a comment on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
congbobo184 removed a comment on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1039845089
@lhotari
if include this pr, run testNG in local will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1040057734
> @lhotari I cannot run the unit test in IDEA since the PR into master branch:
>
> ```
> Error: could not open `{testJacocoAgentArgument}'
> ```
>
> Do you have any ideas?
@nodece @congbobo184 Thanks for notifying about the problem. I'll push a fix soon for #14294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1040060673
@nodece I pushed a fix in #14296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#discussion_r805971584
##########
File path: buildtools/pom.xml
##########
@@ -170,7 +170,7 @@
<value>org.apache.pulsar.tests.PulsarTestListener,org.apache.pulsar.tests.AnnotationListener,org.apache.pulsar.tests.FailFastNotifier</value>
</property>
</properties>
- <argLine>
+ <argLine>@{argLine}
Review comment:
what about using a custom variable name ? argLine is a bit generic
something like
```
<configuration>
<propertyName>jacoco-surefire-args</propertyName>
</configuration>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14278: [Build] Fix jacoco-maven-plugin integration with the build
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14278:
URL: https://github.com/apache/pulsar/pull/14278#issuecomment-1040057734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org