You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gaogaotiantian (via GitHub)" <gi...@apache.org> on 2026/07/13 21:53:47 UTC
[PR] [SPARK-58108][INFRA] Use pyproject.toml for python-312 docker file [spark]
gaogaotiantian opened a new pull request, #57233:
URL: https://github.com/apache/spark/pull/57233
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian closed pull request #57233: [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file
URL: https://github.com/apache/spark/pull/57233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #57233:
URL: https://github.com/apache/spark/pull/57233#issuecomment-4984243453
@HyukjinKwon and @zhengruifeng , this one is ready for review. I don't want to make changes to all the docker images at once just in case I break something. I replaced the dependency list for all python-31x standard images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on code in PR #57233:
URL: https://github.com/apache/spark/pull/57233#discussion_r3618241113
##########
.github/workflows/build_infra_images_cache.yml:
##########
Review Comment:
Good catch. Added the file to `paths` list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #57233:
URL: https://github.com/apache/spark/pull/57233#discussion_r3614051018
##########
pyproject.toml:
##########
@@ -198,3 +212,49 @@ dev = [
{include-group = "pandas_on_spark_extra"},
{include-group = "pipelines"},
]
+
+_ci_connect = [
+ {include-group = "connect"},
+ "grpcio==1.76.0",
+ "grpcio-status==1.76.0",
+ "googleapis-common-protos==1.71.0",
+ "zstandard==0.25.0",
+ "protobuf==6.33.5",
+]
+
+ci_connect_standard = [
+ {include-group = "_ci_connect"},
+ "graphviz==0.20.3",
+]
+
+ci_connect_minimum = [
Review Comment:
Is this internally unresolvable? It pulls in connect (which pins graphviz==0.20.3) via _ci_connect, then also lists graphviz==0.20 directly, so pip install --group ci_connect_minimum combines graphviz==0.20.3,==0.20 and cannot resolve. Latent/non-blocking (no Dockerfile references ci_connect_minimum at head; it is staged for a later python-minimum conversion), but the group as written will fail whoever wires it up, and the apparent intent (loosen graphviz for the minimum image) is defeated by connect's exact pin. Likely should be fixed to ==0.20.3 (or factor the graphviz pin out of connect).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #57233:
URL: https://github.com/apache/spark/pull/57233#issuecomment-5063267203
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/bac7f7560ef3c1ffdc5eab9ddf7558bf60a569a1
- merged into branch-4.x https://github.com/apache/spark/commit/fde9d32f759eb7db30e273cae1e82d54c4e4b17e
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #57233:
URL: https://github.com/apache/spark/pull/57233#discussion_r3614058803
##########
.github/workflows/build_infra_images_cache.yml:
##########
Review Comment:
After this PR, pyproject.toml is the real source of CI dependencies, but the cache-rebuild trigger still lists only Dockerfiles + the workflow file. A pyproject.toml-only dependency bump will no longer re-warm the layer cache, causing cache-miss slowdowns until a Dockerfile is also touched. Correctness unaffected (PR test builds always COPY a fresh pyproject.toml); add pyproject.toml to the `paths:` list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58108][INFRA] Use pyproject.toml for python-31x docker file [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on code in PR #57233:
URL: https://github.com/apache/spark/pull/57233#discussion_r3617850106
##########
pyproject.toml:
##########
@@ -198,3 +212,49 @@ dev = [
{include-group = "pandas_on_spark_extra"},
{include-group = "pipelines"},
]
+
+_ci_connect = [
+ {include-group = "connect"},
+ "grpcio==1.76.0",
+ "grpcio-status==1.76.0",
+ "googleapis-common-protos==1.71.0",
+ "zstandard==0.25.0",
+ "protobuf==6.33.5",
+]
+
+ci_connect_standard = [
+ {include-group = "_ci_connect"},
+ "graphviz==0.20.3",
+]
+
+ci_connect_minimum = [
Review Comment:
You are right. This specific config was not used at this point but we should solve it. I believe we need to change the version requirements for `graphviz` to `>=0.20` for `connect` because that's what we have in our documentation - https://spark.apache.org/docs/latest/api/python/getting_started/install.html . I was trying to change that when I move dependency list from `requirements.txt` but was informed that the PR should be only about refactoring - anything else should be done in a separate PR.
I will change the `graphviz` requirement first then merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org