You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Thomas Kho (JIRA)" <ji...@apache.org> on 2010/03/01 23:36:05 UTC

[jira] Created: (THRIFT-721) THttpClient ignores url parameters

THttpClient ignores url parameters
----------------------------------

                 Key: THRIFT-721
                 URL: https://issues.apache.org/jira/browse/THRIFT-721
             Project: Thrift
          Issue Type: Bug
          Components: Library (Ruby)
            Reporter: Thomas Kho
            Priority: Minor


I recently ran into a situation where I had to pass a parameter to a thrift http endpoint, but noticed that HTTPClientTransport was ignoring it when sending the request.

client = HTTPClientTransport.new('http://www.foo.com/my/service?param=value")
client.do_something

will post to http://www.foo.com/my/service instead of http://www.foo.com/my/service?param=value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-721) THttpClient ignores url parameters

Posted by "Thomas Kho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Kho updated THRIFT-721:
------------------------------

    Attachment: THRIFT-721.txt

Patch to respect query string in THttpClient and generated remotes. Also, add an error message on unknown methods.

> THttpClient ignores url parameters
> ----------------------------------
>
>                 Key: THRIFT-721
>                 URL: https://issues.apache.org/jira/browse/THRIFT-721
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>            Reporter: Thomas Kho
>            Priority: Minor
>         Attachments: THRIFT-721.txt
>
>
> This is similar to THRIFT-720, but for Python.
> THttpClient and the generated remotes currently ignore query strings. This change makes thrift respect them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-721) THttpClient ignores url parameters

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-721.
--------------------------------

         Assignee: Thomas Kho
    Fix Version/s: 0.5
       Resolution: Fixed

I just committed this.

> THttpClient ignores url parameters
> ----------------------------------
>
>                 Key: THRIFT-721
>                 URL: https://issues.apache.org/jira/browse/THRIFT-721
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>            Reporter: Thomas Kho
>            Assignee: Thomas Kho
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: THRIFT-721.txt
>
>
> This is similar to THRIFT-720, but for Python.
> THttpClient and the generated remotes currently ignore query strings. This change makes thrift respect them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-721) THttpClient ignores url parameters

Posted by "Thomas Kho (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Kho updated THRIFT-721:
------------------------------

    Component/s:     (was: Library (Ruby))
                 Library (Python)
    Description: 
This is similar to THRIFT-720, but for Python.

THttpClient and the generated remotes currently ignore query strings. This change makes thrift respect them.

  was:
I recently ran into a situation where I had to pass a parameter to a thrift http endpoint, but noticed that HTTPClientTransport was ignoring it when sending the request.

client = HTTPClientTransport.new('http://www.foo.com/my/service?param=value")
client.do_something

will post to http://www.foo.com/my/service instead of http://www.foo.com/my/service?param=value


> THttpClient ignores url parameters
> ----------------------------------
>
>                 Key: THRIFT-721
>                 URL: https://issues.apache.org/jira/browse/THRIFT-721
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>            Reporter: Thomas Kho
>            Priority: Minor
>
> This is similar to THRIFT-720, but for Python.
> THttpClient and the generated remotes currently ignore query strings. This change makes thrift respect them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.