You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Daniel Kulp (JIRA)" <tu...@ws.apache.org> on 2006/03/23 03:07:00 UTC

[jira] Created: (TUSCANY-127) Fix for "spec" eclipse warnings

Fix for "spec" eclipse warnings
-------------------------------

         Key: TUSCANY-127
         URL: http://issues.apache.org/jira/browse/TUSCANY-127
     Project: Tuscany
        Type: Improvement
  Components: Java Spec APIs  
    Reporter: Daniel Kulp
    Priority: Minor


Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by "Jeremy Boynes (JIRA)" <tu...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/TUSCANY-127?page=comments#action_12371509 ] 

Jeremy Boynes commented on TUSCANY-127:
---------------------------------------

I'm going to request a vote on this on the list as it impacts the JDK version for the spec jars.

> Fix for "spec" eclipse warnings
> -------------------------------
>
>          Key: TUSCANY-127
>          URL: http://issues.apache.org/jira/browse/TUSCANY-127
>      Project: Tuscany
>         Type: Improvement
>   Components: Java Spec APIs
>     Reporter: Daniel Kulp
>     Assignee: Jeremy Boynes
>     Priority: Minor
>  Attachments: spec.patch
>
> Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by "Daniel Kulp (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-127?page=all ]

Daniel Kulp updated TUSCANY-127:
--------------------------------

    Attachment: spec.patch

> Fix for "spec" eclipse warnings
> -------------------------------
>
>          Key: TUSCANY-127
>          URL: http://issues.apache.org/jira/browse/TUSCANY-127
>      Project: Tuscany
>         Type: Improvement
>   Components: Java Spec APIs
>     Reporter: Daniel Kulp
>     Priority: Minor
>  Attachments: spec.patch
>
> Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Closed: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by Jeremy Boynes <jb...@apache.org>.
Daniel Kulp wrote:
> Jeremy,
> 
>> I did not apply the fix to CallbackType as the test is checking that
>> annotations on private fields are accessible. The spec allows this even
>> though it can be annoying when IDEs report (correctly) that the field
>> is not being used.
> 
> Can we add a protected method like:
>     public Object getField() {
>         return cbField;
>     }
> or would adding a method violate the test as well?    I'm just trying to 
> find a way to "use" the field to avoid the warning.
> 

No, the test is pretty dumb so adding something to keep the IDEs happy 
would be fine.
--
Jeremy



Re: [jira] Closed: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by Daniel Kulp <da...@iona.com>.
Jeremy,

> I did not apply the fix to CallbackType as the test is checking that
> annotations on private fields are accessible. The spec allows this even
> though it can be annoying when IDEs report (correctly) that the field
> is not being used.

Can we add a protected method like:
    public Object getField() {
        return cbField;
    }
or would adding a method violate the test as well?    I'm just trying to 
find a way to "use" the field to avoid the warning.

-- 
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727  C: 508-380-7194
daniel.kulp@iona.com

[jira] Closed: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by "Jeremy Boynes (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-127?page=all ]
     
Jeremy Boynes closed TUSCANY-127:
---------------------------------

    Resolution: Fixed

Applied fix for the changes to CurrentModuleContext
I did not apply the fix to CallbackType as the test is checking that annotations on private fields are accessible. The spec allows this even though it can be annoying when IDEs report (correctly) that the field is not being used.

> Fix for "spec" eclipse warnings
> -------------------------------
>
>          Key: TUSCANY-127
>          URL: http://issues.apache.org/jira/browse/TUSCANY-127
>      Project: Tuscany
>         Type: Improvement
>   Components: Java Spec APIs
>     Reporter: Daniel Kulp
>     Assignee: Jeremy Boynes
>     Priority: Minor
>  Attachments: spec.patch
>
> Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by "Jeremy Boynes (JIRA)" <tu...@ws.apache.org>.
    [ http://issues.apache.org/jira/browse/TUSCANY-127?page=comments#action_12371510 ] 

Jeremy Boynes commented on TUSCANY-127:
---------------------------------------

Never mind, I'm being dumb - we're already pre-reqing 1.5 due to all the annotations.

> Fix for "spec" eclipse warnings
> -------------------------------
>
>          Key: TUSCANY-127
>          URL: http://issues.apache.org/jira/browse/TUSCANY-127
>      Project: Tuscany
>         Type: Improvement
>   Components: Java Spec APIs
>     Reporter: Daniel Kulp
>     Assignee: Jeremy Boynes
>     Priority: Minor
>  Attachments: spec.patch
>
> Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (TUSCANY-127) Fix for "spec" eclipse warnings

Posted by "Jeremy Boynes (JIRA)" <tu...@ws.apache.org>.
     [ http://issues.apache.org/jira/browse/TUSCANY-127?page=all ]

Jeremy Boynes reassigned TUSCANY-127:
-------------------------------------

    Assign To: Jeremy Boynes

> Fix for "spec" eclipse warnings
> -------------------------------
>
>          Key: TUSCANY-127
>          URL: http://issues.apache.org/jira/browse/TUSCANY-127
>      Project: Tuscany
>         Type: Improvement
>   Components: Java Spec APIs
>     Reporter: Daniel Kulp
>     Assignee: Jeremy Boynes
>     Priority: Minor
>  Attachments: spec.patch
>
> Minor changes to fix all the compiler warnings in eclipse for all of spec.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira