You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:12:18 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #9186: [Fix-9065] [master] when task submit failed, remove from queue and add state event to thread
caishunfeng commented on a change in pull request #9186:
URL: https://github.com/apache/dolphinscheduler/pull/9186#discussion_r840300541
##########
File path: dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1782,6 +1784,11 @@ private void submitStandByTask() {
TaskInstance taskInstance = submitTaskExec(task);
if (taskInstance == null) {
this.taskFailedSubmit = true;
+ // Remove and add to complete map and error map
+ removeTaskFromStandbyList(task);
+ completeTaskMap.put(task.getTaskCode(), task.getId());
+ errorTaskMap.put(task.getTaskCode(), task.getId());
+ logger.info("process {}, task {}, id:{} submit task failed.", task.getProcessInstanceId(), task.getName(), task.getId());
Review comment:
```suggestion
logger.error("process {}, task {}, code:{} submit task failed.", task.getProcessInstanceId(), task.getName(), task.getCode());
```
##########
File path: dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1782,6 +1784,11 @@ private void submitStandByTask() {
TaskInstance taskInstance = submitTaskExec(task);
if (taskInstance == null) {
this.taskFailedSubmit = true;
+ // Remove and add to complete map and error map
+ removeTaskFromStandbyList(task);
Review comment:
OK, I had changed my mind and agree with you. Due to it already has retry submit logic, so if task submit fail finally, I think mark it error is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org