You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/27 20:36:08 UTC

[GitHub] BasPH commented on a change in pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py

BasPH commented on a change in pull request #4381: [AIRFLOW-3468] Move KnownEventType out of models.py
URL: https://github.com/apache/incubator-airflow/pull/4381#discussion_r244221718
 
 

 ##########
 File path: airflow/utils/db.py
 ##########
 @@ -28,6 +28,7 @@
 import contextlib
 
 from airflow import settings
+from airflow.models.knowneventtype import KnownEventType
 
 Review comment:
   Sure. For consistency, I think it would then be best for all /airflow/models/*.py files to be named the same as the SQLAlchemy table name which are all written with underscores, so I'll stick to that if that's okay (since I'll [move more classes from models.py](https://issues.apache.org/jira/issues/?jql=text%20~%20%22Refactor%3A%20Move%20out%20of%20models.py%22%20AND%20reporter%20in%20(Fokko%2C%20BasPH))).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services