[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build

[GitBox <gi...@apache.org>]

olamy commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924326645


##########
.github/workflows/maven-verify.yml:
##########
@@ -184,10 +184,17 @@ jobs:
 
       - name: Build with Maven
         run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
+        
+      - name: Clean Ensuring no file handle remains open on windows
+        run: ./mvnw clean --errors --batch-mode --show-version           
 
       - name: Build Maven Site
         run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-site-goal }}
         if: inputs.ff-site-run
+        
+      - name: Clean Ensuring no file handle remains open on windows
+        if: steps.should-run.conclusion == 'success'
+        run: ./mvnw clean --errors --batch-mode --show-version            

Review Comment:
   yup we don't know if the basic build or the site build is locking.
   but that would be nit picking



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org