You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/28 10:39:19 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #18662: add validate for drop table cascade
tuichenchuxin opened a new pull request, #18662:
URL: https://github.com/apache/shardingsphere/pull/18662
Fixes #18432.
For #17915
Changes proposed in this pull request:
- add validate for drop table cascade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18662: add validate for drop table cascade
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18662:
URL: https://github.com/apache/shardingsphere/pull/18662#issuecomment-1168591623
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18662](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37291eb) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c3690e8a7dcb03fa259c5816805d307af3861f9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3690e8) will **decrease** coverage by `0.00%`.
> The diff coverage is `35.00%`.
```diff
@@ Coverage Diff @@
## master #18662 +/- ##
============================================
- Coverage 59.39% 59.38% -0.01%
Complexity 2259 2259
============================================
Files 3727 3728 +1
Lines 54763 54796 +33
Branches 9322 9332 +10
============================================
+ Hits 32524 32540 +16
- Misses 19499 19514 +15
- Partials 2740 2742 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dbdiscovery/algorithm/DatabaseDiscoveryEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9hbGdvcml0aG0vRGF0YWJhc2VEaXNjb3ZlcnlFbmdpbmUuamF2YQ==) | `37.50% <ø> (ø)` | |
| [.../ddl/impl/ShardingDropTableStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3ZhbGlkYXRvci9kZGwvaW1wbC9TaGFyZGluZ0Ryb3BUYWJsZVN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `88.88% <0.00%> (-7.12%)` | :arrow_down: |
| [...e/validator/ddl/SingleTableDropTableValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcm91dGUvdmFsaWRhdG9yL2RkbC9TaW5nbGVUYWJsZURyb3BUYWJsZVZhbGlkYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dialect/handler/ddl/DropTableStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RkbC9Ecm9wVGFibGVTdGF0ZW1lbnRIYW5kbGVyLmphdmE=) | `50.00% <0.00%> (-27.78%)` | :arrow_down: |
| [...validator/SingleTableMetadataValidatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNpbmdsZS10YWJsZS9zaGFyZGluZ3NwaGVyZS1zaW5nbGUtdGFibGUtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2luZ2xldGFibGUvcm91dGUvdmFsaWRhdG9yL1NpbmdsZVRhYmxlTWV0YWRhdGFWYWxpZGF0b3JGYWN0b3J5LmphdmE=) | `60.00% <60.00%> (-40.00%)` | :arrow_down: |
| [...tatement/impl/OpenGaussDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3BlbmdhdXNzL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3BlbkdhdXNzRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `80.44% <100.00%> (+0.05%)` | :arrow_up: |
| [...atement/impl/PostgreSQLDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `83.63% <100.00%> (+0.04%)` | :arrow_up: |
| [...aling/query/QueryableScalingRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3NjYWxpbmcvcXVlcnkvUXVlcnlhYmxlU2NhbGluZ1JBTEJhY2tlbmRIYW5kbGVyLmphdmE=) | `58.82% <0.00%> (-24.51%)` | :arrow_down: |
| [.../proxy/backend/response/data/QueryResponseRow.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9yZXNwb25zZS9kYXRhL1F1ZXJ5UmVzcG9uc2VSb3cuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [.../text/data/impl/UnicastDatabaseBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2RhdGEvaW1wbC9VbmljYXN0RGF0YWJhc2VCYWNrZW5kSGFuZGxlci5qYXZh) | `20.68% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/18662/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c3690e8...37291eb](https://codecov.io/gh/apache/shardingsphere/pull/18662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #18662: add validate for drop table cascade
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #18662:
URL: https://github.com/apache/shardingsphere/pull/18662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org