You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ji...@apache.org on 2019/03/05 21:50:11 UTC
[incubator-pinot] branch master updated: [TE] frontend -
harleyjj/alert-overview - handle empty responses better (#3908)
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dbf02c8 [TE] frontend - harleyjj/alert-overview - handle empty responses better (#3908)
dbf02c8 is described below
commit dbf02c8d361c6cb6d7ee1fb1f35eccdb061b01e5
Author: Harley Jackson <ha...@gmail.com>
AuthorDate: Tue Mar 5 13:50:07 2019 -0800
[TE] frontend - harleyjj/alert-overview - handle empty responses better (#3908)
---
thirdeye/thirdeye-frontend/app/pods/manage/explore-new/route.js | 4 ++--
thirdeye/thirdeye-frontend/app/pods/manage/yaml/route.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/manage/explore-new/route.js b/thirdeye/thirdeye-frontend/app/pods/manage/explore-new/route.js
index fd5efd4..71947c6 100644
--- a/thirdeye/thirdeye-frontend/app/pods/manage/explore-new/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/manage/explore-new/route.js
@@ -78,11 +78,11 @@ export default Route.extend({
alertId,
subscriptionGroupId,
alertData: get(this, 'detectionYaml'),
- detectionYaml: get(this, 'detectionYaml').yaml,
+ detectionYaml: get(this, 'detectionYaml') ? get(this, 'detectionYaml').yaml : null,
subscriptionGroups: get(this, 'subscriptionGroups'),
subscriptionGroupYamlDisplay,
metricUrn: get(this, 'metricUrn'),
- metricUrnList: get(this, 'metricUrnList')
+ metricUrnList: get(this, 'metricUrnList') || []
});
},
diff --git a/thirdeye/thirdeye-frontend/app/pods/manage/yaml/route.js b/thirdeye/thirdeye-frontend/app/pods/manage/yaml/route.js
index 915f68c..4a8ffeb 100644
--- a/thirdeye/thirdeye-frontend/app/pods/manage/yaml/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/manage/yaml/route.js
@@ -72,7 +72,7 @@ export default Route.extend({
alertId,
subscriptionGroupId,
alertData: get(this, 'detectionYaml'),
- detectionYaml: get(this, 'detectionYaml').yaml,
+ detectionYaml: get (this, 'detectionYaml') ? get(this, 'detectionYaml').yaml : 'Yaml retrieval failed',
subscriptionGroups: get(this, 'subscriptionGroups'),
subscriptionGroupYamlDisplay
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org