You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Mingfai Ma (JIRA)" <ji...@apache.org> on 2009/07/17 09:59:14 UTC
[jira] Created: (DROIDS-56) Change the TaskQueue interface to
java.util.Queue
Change the TaskQueue interface to java.util.Queue
-------------------------------------------------
Key: DROIDS-56
URL: https://issues.apache.org/jira/browse/DROIDS-56
Project: Droids
Issue Type: Improvement
Components: core
Affects Versions: 0.01
Reporter: Mingfai Ma
1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
2. either remove the TaskQueue or make it extends java.util.Queue
- it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-56) Change the TaskQueue interface to
java.util.Queue
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Frovarp updated DROIDS-56:
----------------------------------
Attachment: taskQueue-to-queue.diff
This should do it. It passes test and findbugs.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DROIDS-56) Change the TaskQueue
interface to java.util.Queue
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862864#action_12862864 ]
Bertil Chapuis edited comment on DROIDS-56 at 4/30/10 5:01 PM:
---------------------------------------------------------------
Replace completely the TaskQueue by java.util.Queue. It also contains changes to the TaskMaster (DROIDS-51). The tests pass after few modifications.
was (Author: bertil):
Replace completely the TaskQueue by java.util.Queue. It also contains changes to the TaskMaster. The tests pass after few modifications (DROIDS-51).
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: Queue.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DROIDS-56) Change the TaskQueue interface to
java.util.Queue
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843281#action_12843281 ]
Bertil Chapuis commented on DROIDS-56:
--------------------------------------
A standard interface is for sure preferable to the TaskQueue. A List<T> may also be a good option. Entity Managers use List to store query results and and Entity may as well implement the Task interface. This could really simplify the persistence of the queue elements.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.01
> Reporter: Mingfai Ma
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DROIDS-56) Change the TaskQueue
interface to java.util.Queue
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862864#action_12862864 ]
Bertil Chapuis edited comment on DROIDS-56 at 4/30/10 5:00 PM:
---------------------------------------------------------------
Replace completely the TaskQueue by java.util.Queue. It also contains changes to the TaskMaster. The tests pass after few modifications.
was (Author: bertil):
Replace completely the TaskQueue by java.util.Queue. It also contains. Also contains changes to the TaskMaster. The tests pass after few modifications.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: Queue.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DROIDS-56) Change the TaskQueue interface to
java.util.Queue
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated DROIDS-56:
---------------------------------
Attachment: Queue.diff
Replace completely the TaskQueue by java.util.Queue. It also contains. Also contains changes to the TaskMaster. The tests pass after few modifications.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: Queue.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DROIDS-56) Change the TaskQueue
interface to java.util.Queue
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862864#action_12862864 ]
Bertil Chapuis edited comment on DROIDS-56 at 4/30/10 5:01 PM:
---------------------------------------------------------------
Replace completely the TaskQueue by java.util.Queue. It also contains changes to the TaskMaster. The tests pass after few modifications (DROIDS-51).
was (Author: bertil):
Replace completely the TaskQueue by java.util.Queue. It also contains changes to the TaskMaster. The tests pass after few modifications.
> Change the TaskQueue interface to java.util.Queue
> -------------------------------------------------
>
> Key: DROIDS-56
> URL: https://issues.apache.org/jira/browse/DROIDS-56
> Project: Droids
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.0.1
> Reporter: Mingfai Ma
> Attachments: Queue.diff, taskQueue-to-queue.diff
>
>
> 1. any code that depends on the queue should depend on java.util.Queue<T> rather than TaskQueue.
> 2. either remove the TaskQueue or make it extends java.util.Queue
> - it means SimpleTaskQueue should extends a Queue implementation (or implement all method of a Queue)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.