You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/12 17:13:10 UTC

[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

iverase commented on code in PR #809:
URL: https://github.com/apache/lucene/pull/809#discussion_r848675478


##########
lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java:
##########
@@ -257,10 +257,13 @@ public WithinRelation withinLine(
       boolean ab,
       double bX,
       double bY) {
-    if (ab == true

Review Comment:
   I don't think we can do that now as we need to distinguish better between DISJOINT and WITHIN. The previous logic was not right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org