You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Elliott Clark (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 22:42:40 UTC
[jira] [Created] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
HRegion.incrementColumnValue is not used in trunk
-------------------------------------------------
Key: HBASE-5824
URL: https://issues.apache.org/jira/browse/HBASE-5824
Project: HBase
Issue Type: Bug
Reporter: Elliott Clark
Assignee: Jimmy Xiang
on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257083#comment-13257083 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
I will add a unit test for this and fix it.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Attachment: hbase-5824.patch
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Status: Patch Available (was: Open)
This patch is to enhance single puts to use mutate directly instead of multiput.
For HRegion#incrementColumnValue, I think it is ok not to use it.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Attachment: hbase-5824_v2.patch
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Status: Patch Available (was: Open)
I added a deprecation annotation to HRegion#incrementColumnValue
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257881#comment-13257881 ]
Hadoop QA commented on HBASE-5824:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523410/hbase-5824.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1583//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1583//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1583//console
This message is automatically generated.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258269#comment-13258269 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
Implication of this JIRA is that the type of exception thrown when certain constraint isn't satisfied differs depending on whether auto flush is enabled.
When I changed the test case slightly:
{code}
Index: src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
===================================================================
--- src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java (revision 1328376)
+++ src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java (working copy)
@@ -105,7 +105,7 @@
util.getHBaseAdmin().createTable(desc);
HTable table = new HTable(util.getConfiguration(), tableName);
- table.setAutoFlush(true);
+ table.setAutoFlush(false);
// test that we do fail on violation
Put put = new Put(row1);
{code}
I got:
{code}
testConstraintFails(org.apache.hadoop.hbase.constraint.TestConstraint) Time elapsed: 4.144 sec <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:92)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at org.apache.hadoop.hbase.constraint.TestConstraint.testConstraintFails(TestConstraint.java:118)
{code}
This makes exception handling unnecessarily complicated.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257989#comment-13257989 ]
Hudson commented on HBASE-5824:
-------------------------------
Integrated in HBase-TRUNK #2790 (See [https://builds.apache.org/job/HBase-TRUNK/2790/])
HBASE-5824 addendum fixes coprocessor tests (Jimmy) (Revision 1328166)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258463#comment-13258463 ]
Hudson commented on HBASE-5824:
-------------------------------
Integrated in HBase-TRUNK #2791 (See [https://builds.apache.org/job/HBase-TRUNK/2791/])
HBASE-5824 revert changes to single Put case, preserving deprecation for ICV (Revision 1328457)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258390#comment-13258390 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
I talked with Jimmy offline. We agree that single Put execution path isn't of high priority.
We will leave the discussion and decision making to HBASE-5845.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257928#comment-13257928 ]
Hudson commented on HBASE-5824:
-------------------------------
Integrated in HBase-TRUNK #2788 (See [https://builds.apache.org/job/HBase-TRUNK/2788/])
HBASE-5824 HRegion.incrementColumnValue is not used in trunk (Revision 1328142)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257961#comment-13257961 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
+1 on Addendum.
The two tests pass with addendum:
{code}
542 mt -Dtest=TestConstraint
543 mt -Dtest=TestRegionServerCoprocessorExceptionWithRemove
{code}
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Status: Patch Available (was: Reopened)
Fixed the unit tests. Sorry for that.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258293#comment-13258293 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
Constraint is in 0.94
This change causes regression in the way client responds to Constraint violation.
Now client has to deal with two exceptions instead of only one exception (in 0.94)
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257874#comment-13257874 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
Minor comment:
The line below exceeds 100 characters.
{code}
+ // we need to periodically see if the writebuffer is full instead of waiting until the end of the List
{code}
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258411#comment-13258411 ]
Hadoop QA commented on HBASE-5824:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523521/5824-addendum-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1593//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1593//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1593//console
This message is automatically generated.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257859#comment-13257859 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
{code}
+ if (autoFlush && puts.size() == 1) {
{code}
How is autoFlush related to single put ?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257865#comment-13257865 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
If autoFlush is not enabled, Puts are most likely batched. It is not very efficient to check if a batch contains only one Put, which is kind of duplicate some of the multiput logic.
You can say the patch is not strictly for single put.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257904#comment-13257904 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
I am looking into it.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258024#comment-13258024 ]
Hudson commented on HBASE-5824:
-------------------------------
Integrated in HBase-TRUNK-security #176 (See [https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5824 addendum fixes coprocessor tests (Jimmy) (Revision 1328166)
HBASE-5824 HRegion.incrementColumnValue is not used in trunk (Revision 1328142)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258373#comment-13258373 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
Yes, this patch is for 0.96 only.
RetriesExhaustedWithDetailsException applies to batch processing only.
For single action, individual exception is used. Currently only Put is implicitly batched.
Should I change single Put to use RetriesExhaustedWithDetailsException too?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258381#comment-13258381 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
@Ted, I filed HBASE-5845. Thanks for pointing out the issue. Good catch.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258377#comment-13258377 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
@Jimmy:
Shall we pursue your proposal in a separate JIRA so that we can keep the original intent of this JIRA ?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257965#comment-13257965 ]
Hadoop QA commented on HBASE-5824:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523437/hbase_5824.addendum
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1588//console
This message is automatically generated.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257963#comment-13257963 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
Integrated addendum to TRUNK.
Thanks for the quick turn around, Jimmy.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Elliott Clark (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257848#comment-13257848 ]
Elliott Clark commented on HBASE-5824:
--------------------------------------
Looking through it everything seems to be good. I can't see anything that ICV does that increment doesn't.
Should the old code get removed then ?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Elliott Clark (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257110#comment-13257110 ]
Elliott Clark commented on HBASE-5824:
--------------------------------------
Thanks.
Looks like single puts are also only going through the multiput method. I'm not sure if this is an issue that needs to be fixed as well.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257143#comment-13257143 ]
Jimmy Xiang commented on HBASE-5824:
------------------------------------
I looked into it and it seems not a bug. HRegion#incrementColumnValue is a redundant method.
HRegion#increment can do the same thing. That's why I used HRegion#increment. Anything wrong with that?
As to the single puts, the reason is that the client side tries to use batch processing. This behaves the
same as before. Of course, we can enhance it. I will do it in HBASE-5621.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257893#comment-13257893 ]
Hadoop QA commented on HBASE-5824:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523412/hbase-5824_v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1584//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1584//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1584//console
This message is automatically generated.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Attachment: hbase_5824.addendum
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5824:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for patch Jimmy.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5824:
------------------------------
Attachment: 5824-addendum-v2.txt
Proposed addendum that matches the original intent of the JIRA.
There is no strong reason for the change in HTable.doPut(final List<Put> puts)
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu reopened HBASE-5824:
-------------------------------
I can reproduce one of the test failures reported by Hadoop QA:
{code}
testConstraintFails(org.apache.hadoop.hbase.constraint.TestConstraint) Time elapsed: 3.174 sec <<< ERROR!
org.apache.hadoop.hbase.constraint.ConstraintException: org.apache.hadoop.hbase.constraint.ConstraintException: AllFailConstraint fails for all puts
...
Caused by: org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hbase.constraint.ConstraintException: AllFailConstraint fails for all puts
at org.apache.hadoop.hbase.constraint.AllFailConstraint.check(AllFailConstraint.java:29)
at org.apache.hadoop.hbase.constraint.ConstraintProcessor.prePut(ConstraintProcessor.java:87)
at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.prePut(RegionCoprocessorHost.java:656)
at org.apache.hadoop.hbase.regionserver.HRegion.internalPut(HRegion.java:2434)
at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1891)
at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1857)
at org.apache.hadoop.hbase.regionserver.RegionServer.mutate(RegionServer.java:523)
{code}
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257849#comment-13257849 ]
stack commented on HBASE-5824:
------------------------------
+1 on the Jimmy patch.
@Elliott At least add a deprecate pointing to preferred code I'd say?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258777#comment-13258777 ]
Hudson commented on HBASE-5824:
-------------------------------
Integrated in HBase-TRUNK-security #177 (See [https://builds.apache.org/job/HBase-TRUNK-security/177/])
HBASE-5824 revert changes to single Put case, preserving deprecation for ICV (Revision 1328457)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258313#comment-13258313 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
In 0.94, client only needs to deal with RetriesExhaustedWithDetailsException whose only cause is a ConstraintException
With Jimmy's patch, client needs to deal with RetriesExhaustedWithDetailsException (not subclass of DoNotRetryIOException) and ConstraintException (subclass of DoNotRetryIOException). This is because there're two execution paths for Put.
I am afraid Benoit would have more to complain about in HBASE-5796 :-)
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258400#comment-13258400 ]
Zhihong Yu commented on HBASE-5824:
-----------------------------------
Integrated addendum v2 to trunk.
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: 5824-addendum-v2.txt, hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258297#comment-13258297 ]
stack commented on HBASE-5824:
------------------------------
This patch only makes sense in trunk, not in 0.94.
What are the exceptions that now are different?
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not
used in trunk
Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy Xiang updated HBASE-5824:
-------------------------------
Status: Open (was: Patch Available)
> HRegion.incrementColumnValue is not used in trunk
> -------------------------------------------------
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
> Issue Type: Bug
> Reporter: Elliott Clark
> Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause HRegion#incrementColumnValue. On trunk all calls to HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize to the same thing over the wire so that the remote HRegionServer no longer knows which htable method was called.
> To repro I checked out trunk and put a break point in HRegion#incrementColumnValue and then ran TestFromClientSide. The breakpoint wasn't hit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira