[GitHub] thrift pull request #1519: THRIFT-4214: map key treated as hex va...

[thexeos <gi...@git.apache.org>]

GitHub user thexeos opened a pull request:

    https://github.com/apache/thrift/pull/1519

    THRIFT-4214: map<i64,value> key treated as hex value in JavaScript

    All strings passed to [node-int64 constructor](https://github.com/broofa/node-int64/blob/c1567475712cb1cfe100c96813c2a2a92e2b42ce/Int64.js#L49) are treated as hex strings. We need to convert all decimal strings to hex representation before passing them to the constructor.
    
    We are making an assumption that no hex string will be passed to `writeI64()` without 0x prefix.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thexeos/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1519.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1519
    
----
commit 8ef113fd814ce195d06ee9c935ff702d3053c2b5
Author: thexeos <te...@...>
Date:   2018-03-23T22:06:16Z

    THRIFT-4214: map<i64,value> key treated as hex value in JavaScript

----


---

[GitHub] thrift issue #1519: THRIFT-4214: map key treated as hex value in ...

[thexeos <gi...@git.apache.org>]

Github user thexeos commented on the issue:

    https://github.com/apache/thrift/pull/1519
  
    The tests fail at ``TypeError: binary.readI64 is not a function``, even though the function [exists](https://github.com/thexeos/thrift/blob/b5ceb251b200359d93d55386b70e7d6fc4b0fed8/lib/nodejs/lib/thrift/binary_protocol.js#L314).


---