You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Thomas Weise <th...@apache.org> on 2016/11/08 13:54:19 UTC
[PROPOSAL] Merge apex-runner to master branch
Hi,
As per previous discussion [1], I would like to propose to merge the
apex-runner branch into master. The runner satisfies the criteria outlined
in [2] and merging it to master will give more visibility to other
contributors and users.
Specifically the Apex runner addresses:
- Have at least 2 contributors interested in maintaining it, and 1
committer interested in supporting it: *I'm going to sign up for the
support and there are more folks interested. Some have already contributed
and helped with PR reviews, others from the Apex community have expressed
interest [3].*
- Provide both end-user and developer-facing documentation: *Runner has
README, capability matrix, Javadoc. Planning to add it to the tutorial
later.*
- Have at least a basic level of unit test coverage: *Has 30 runner
specific tests and passes all Beam RunnableOnService tests.*
- Run all existing applicable integration tests with other Beam
components and create additional tests as appropriate: * Enabled runner
for examples integration tests in the same way as other runners.*
- Be able to handle a subset of the model that address a significant set of
use cases (aka. ‘traditional batch’ or ‘processing time
streaming’): *Passes
RunnableOnService without exclusions and example IT.*
- Update the capability matrix with the current status: *Done.*
- Add a webpage under learn/runners: *Same "TODO" page as other runners
added to site.*
The PR for the merge: https://github.com/apache/incubator-beam/pull/1305
(There are intermittent test failures in individual Travis runs that are
unrelated to the runner.)
Thanks,
Thomas
[1]
https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec6484f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
[2] http://beam.apache.org/contribute/contribution-guide/#feature-branches
[3]
https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547
<https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
130691d52@%3Cdev.apex.apache.org%3E
<https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Dan Halperin <dh...@google.com.INVALID>.
Nice! +1
On Tue, Nov 8, 2016 at 10:06 AM, Thomas Groh <tg...@apache.org> wrote:
> +1. Sweet (and congratulations)
>
> On Tue, Nov 8, 2016 at 9:57 AM, Kenneth Knowles <kl...@google.com.invalid>
> wrote:
>
> > +1, with enthusiasm.
> >
> > On Tue, Nov 8, 2016 at 9:16 AM, Davor Bonaci <da...@google.com.invalid>
> > wrote:
> >
> > > +1
> > >
> > > I'd treat this as an official vote on this procedural matter.
> > >
> > > On Tue, Nov 8, 2016 at 6:55 AM, Mukul Jain <mu...@gmail.com> wrote:
> > >
> > > > +1
> > > >
> > > > Awesome work Thomas! More runner choices the better.
> > > >
> > > > Best
> > > > Mukul
> > > >
> > > > Sent from my iPhone
> > > >
> > > > > On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > > > wrote:
> > > > >
> > > > > +1
> > > > >
> > > > > Great work Thomas !!
> > > > >
> > > > > Regards
> > > > > JB
> > > > >
> > > > >
> > > > >
> > > > >> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org>
> > wrote:
> > > > >> Hi,
> > > > >>
> > > > >> As per previous discussion [1], I would like to propose to merge
> the
> > > > >> apex-runner branch into master. The runner satisfies the criteria
> > > > >> outlined
> > > > >> in [2] and merging it to master will give more visibility to other
> > > > >> contributors and users.
> > > > >>
> > > > >> Specifically the Apex runner addresses:
> > > > >>
> > > > >> - Have at least 2 contributors interested in maintaining it, and
> 1
> > > > >> committer interested in supporting it: *I'm going to sign up for
> > the
> > > > >> support and there are more folks interested. Some have already
> > > > >> contributed
> > > > >> and helped with PR reviews, others from the Apex community have
> > > > >> expressed
> > > > >> interest [3].*
> > > > >> - Provide both end-user and developer-facing documentation:
> *Runner
> > > > >> has
> > > > >> README, capability matrix, Javadoc. Planning to add it to the
> > tutorial
> > > > >> later.*
> > > > >> - Have at least a basic level of unit test coverage: *Has 30
> > runner
> > > > >> specific tests and passes all Beam RunnableOnService tests.*
> > > > >> - Run all existing applicable integration tests with other Beam
> > > > >> components and create additional tests as appropriate: * Enabled
> > > runner
> > > > >> for examples integration tests in the same way as other runners.*
> > > > >> - Be able to handle a subset of the model that address a
> significant
> > > > >> set of
> > > > >> use cases (aka. ‘traditional batch’ or ‘processing time
> > > > >> streaming’): *Passes
> > > > >> RunnableOnService without exclusions and example IT.*
> > > > >> - Update the capability matrix with the current status: *Done.*
> > > > >> - Add a webpage under learn/runners: *Same "TODO" page as other
> > > runners
> > > > >> added to site.*
> > > > >>
> > > > >> The PR for the merge:
> > > > >> https://github.com/apache/incubator-beam/pull/1305
> > > > >>
> > > > >> (There are intermittent test failures in individual Travis runs
> that
> > > > >> are
> > > > >> unrelated to the runner.)
> > > > >>
> > > > >> Thanks,
> > > > >> Thomas
> > > > >>
> > > > >> [1]
> > > > >> https://lists.apache.org/thread.html/
> 2b420a35f05e47561f27c19e8ec648
> > > > 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> > > > >>
> > > > >> [2]
> > > > >> http://beam.apache.org/contribute/contribution-guide/
> > > #feature-branches
> > > > >>
> > > > >> [3]
> > > > >> https://lists.apache.org/thread.html/
> 6e7618768cdcde81c28aa9883a1fcf
> > > > 4d3d4e41de4249547
> > > > >> <https://lists.apache.org/thread.html/
> > 6e7618768cdcde81c28aa9883a1fcf
> > > > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > > > >> 130691d52@%3Cdev.apex.apache.org%3E
> > > > >> <https://lists.apache.org/thread.html/
> > 6e7618768cdcde81c28aa9883a1fcf
> > > > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > > >
> > >
> >
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Thomas Groh <tg...@apache.org>.
+1. Sweet (and congratulations)
On Tue, Nov 8, 2016 at 9:57 AM, Kenneth Knowles <kl...@google.com.invalid>
wrote:
> +1, with enthusiasm.
>
> On Tue, Nov 8, 2016 at 9:16 AM, Davor Bonaci <da...@google.com.invalid>
> wrote:
>
> > +1
> >
> > I'd treat this as an official vote on this procedural matter.
> >
> > On Tue, Nov 8, 2016 at 6:55 AM, Mukul Jain <mu...@gmail.com> wrote:
> >
> > > +1
> > >
> > > Awesome work Thomas! More runner choices the better.
> > >
> > > Best
> > > Mukul
> > >
> > > Sent from my iPhone
> > >
> > > > On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > > wrote:
> > > >
> > > > +1
> > > >
> > > > Great work Thomas !!
> > > >
> > > > Regards
> > > > JB
> > > >
> > > >
> > > >
> > > >> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org>
> wrote:
> > > >> Hi,
> > > >>
> > > >> As per previous discussion [1], I would like to propose to merge the
> > > >> apex-runner branch into master. The runner satisfies the criteria
> > > >> outlined
> > > >> in [2] and merging it to master will give more visibility to other
> > > >> contributors and users.
> > > >>
> > > >> Specifically the Apex runner addresses:
> > > >>
> > > >> - Have at least 2 contributors interested in maintaining it, and 1
> > > >> committer interested in supporting it: *I'm going to sign up for
> the
> > > >> support and there are more folks interested. Some have already
> > > >> contributed
> > > >> and helped with PR reviews, others from the Apex community have
> > > >> expressed
> > > >> interest [3].*
> > > >> - Provide both end-user and developer-facing documentation: *Runner
> > > >> has
> > > >> README, capability matrix, Javadoc. Planning to add it to the
> tutorial
> > > >> later.*
> > > >> - Have at least a basic level of unit test coverage: *Has 30
> runner
> > > >> specific tests and passes all Beam RunnableOnService tests.*
> > > >> - Run all existing applicable integration tests with other Beam
> > > >> components and create additional tests as appropriate: * Enabled
> > runner
> > > >> for examples integration tests in the same way as other runners.*
> > > >> - Be able to handle a subset of the model that address a significant
> > > >> set of
> > > >> use cases (aka. ‘traditional batch’ or ‘processing time
> > > >> streaming’): *Passes
> > > >> RunnableOnService without exclusions and example IT.*
> > > >> - Update the capability matrix with the current status: *Done.*
> > > >> - Add a webpage under learn/runners: *Same "TODO" page as other
> > runners
> > > >> added to site.*
> > > >>
> > > >> The PR for the merge:
> > > >> https://github.com/apache/incubator-beam/pull/1305
> > > >>
> > > >> (There are intermittent test failures in individual Travis runs that
> > > >> are
> > > >> unrelated to the runner.)
> > > >>
> > > >> Thanks,
> > > >> Thomas
> > > >>
> > > >> [1]
> > > >> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648
> > > 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> > > >>
> > > >> [2]
> > > >> http://beam.apache.org/contribute/contribution-guide/
> > #feature-branches
> > > >>
> > > >> [3]
> > > >> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > > 4d3d4e41de4249547
> > > >> <https://lists.apache.org/thread.html/
> 6e7618768cdcde81c28aa9883a1fcf
> > > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > > >> 130691d52@%3Cdev.apex.apache.org%3E
> > > >> <https://lists.apache.org/thread.html/
> 6e7618768cdcde81c28aa9883a1fcf
> > > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > >
> >
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
+1, with enthusiasm.
On Tue, Nov 8, 2016 at 9:16 AM, Davor Bonaci <da...@google.com.invalid>
wrote:
> +1
>
> I'd treat this as an official vote on this procedural matter.
>
> On Tue, Nov 8, 2016 at 6:55 AM, Mukul Jain <mu...@gmail.com> wrote:
>
> > +1
> >
> > Awesome work Thomas! More runner choices the better.
> >
> > Best
> > Mukul
> >
> > Sent from my iPhone
> >
> > > On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> > wrote:
> > >
> > > +1
> > >
> > > Great work Thomas !!
> > >
> > > Regards
> > > JB
> > >
> > >
> > >
> > >> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org> wrote:
> > >> Hi,
> > >>
> > >> As per previous discussion [1], I would like to propose to merge the
> > >> apex-runner branch into master. The runner satisfies the criteria
> > >> outlined
> > >> in [2] and merging it to master will give more visibility to other
> > >> contributors and users.
> > >>
> > >> Specifically the Apex runner addresses:
> > >>
> > >> - Have at least 2 contributors interested in maintaining it, and 1
> > >> committer interested in supporting it: *I'm going to sign up for the
> > >> support and there are more folks interested. Some have already
> > >> contributed
> > >> and helped with PR reviews, others from the Apex community have
> > >> expressed
> > >> interest [3].*
> > >> - Provide both end-user and developer-facing documentation: *Runner
> > >> has
> > >> README, capability matrix, Javadoc. Planning to add it to the tutorial
> > >> later.*
> > >> - Have at least a basic level of unit test coverage: *Has 30 runner
> > >> specific tests and passes all Beam RunnableOnService tests.*
> > >> - Run all existing applicable integration tests with other Beam
> > >> components and create additional tests as appropriate: * Enabled
> runner
> > >> for examples integration tests in the same way as other runners.*
> > >> - Be able to handle a subset of the model that address a significant
> > >> set of
> > >> use cases (aka. ‘traditional batch’ or ‘processing time
> > >> streaming’): *Passes
> > >> RunnableOnService without exclusions and example IT.*
> > >> - Update the capability matrix with the current status: *Done.*
> > >> - Add a webpage under learn/runners: *Same "TODO" page as other
> runners
> > >> added to site.*
> > >>
> > >> The PR for the merge:
> > >> https://github.com/apache/incubator-beam/pull/1305
> > >>
> > >> (There are intermittent test failures in individual Travis runs that
> > >> are
> > >> unrelated to the runner.)
> > >>
> > >> Thanks,
> > >> Thomas
> > >>
> > >> [1]
> > >> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648
> > 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> > >>
> > >> [2]
> > >> http://beam.apache.org/contribute/contribution-guide/
> #feature-branches
> > >>
> > >> [3]
> > >> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547
> > >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > >> 130691d52@%3Cdev.apex.apache.org%3E
> > >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> >
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Davor Bonaci <da...@google.com.INVALID>.
+1
I'd treat this as an official vote on this procedural matter.
On Tue, Nov 8, 2016 at 6:55 AM, Mukul Jain <mu...@gmail.com> wrote:
> +1
>
> Awesome work Thomas! More runner choices the better.
>
> Best
> Mukul
>
> Sent from my iPhone
>
> > On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
> >
> > +1
> >
> > Great work Thomas !!
> >
> > Regards
> > JB
> >
> >
> >
> >> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org> wrote:
> >> Hi,
> >>
> >> As per previous discussion [1], I would like to propose to merge the
> >> apex-runner branch into master. The runner satisfies the criteria
> >> outlined
> >> in [2] and merging it to master will give more visibility to other
> >> contributors and users.
> >>
> >> Specifically the Apex runner addresses:
> >>
> >> - Have at least 2 contributors interested in maintaining it, and 1
> >> committer interested in supporting it: *I'm going to sign up for the
> >> support and there are more folks interested. Some have already
> >> contributed
> >> and helped with PR reviews, others from the Apex community have
> >> expressed
> >> interest [3].*
> >> - Provide both end-user and developer-facing documentation: *Runner
> >> has
> >> README, capability matrix, Javadoc. Planning to add it to the tutorial
> >> later.*
> >> - Have at least a basic level of unit test coverage: *Has 30 runner
> >> specific tests and passes all Beam RunnableOnService tests.*
> >> - Run all existing applicable integration tests with other Beam
> >> components and create additional tests as appropriate: * Enabled runner
> >> for examples integration tests in the same way as other runners.*
> >> - Be able to handle a subset of the model that address a significant
> >> set of
> >> use cases (aka. ‘traditional batch’ or ‘processing time
> >> streaming’): *Passes
> >> RunnableOnService without exclusions and example IT.*
> >> - Update the capability matrix with the current status: *Done.*
> >> - Add a webpage under learn/runners: *Same "TODO" page as other runners
> >> added to site.*
> >>
> >> The PR for the merge:
> >> https://github.com/apache/incubator-beam/pull/1305
> >>
> >> (There are intermittent test failures in individual Travis runs that
> >> are
> >> unrelated to the runner.)
> >>
> >> Thanks,
> >> Thomas
> >>
> >> [1]
> >> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648
> 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> >>
> >> [2]
> >> http://beam.apache.org/contribute/contribution-guide/#feature-branches
> >>
> >> [3]
> >> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547
> >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> >> 130691d52@%3Cdev.apex.apache.org%3E
> >> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Mukul Jain <mu...@gmail.com>.
+1
Awesome work Thomas! More runner choices the better.
Best
Mukul
Sent from my iPhone
> On Nov 8, 2016, at 6:09 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> +1
>
> Great work Thomas !!
>
> Regards
> JB
>
>
>
>> On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org> wrote:
>> Hi,
>>
>> As per previous discussion [1], I would like to propose to merge the
>> apex-runner branch into master. The runner satisfies the criteria
>> outlined
>> in [2] and merging it to master will give more visibility to other
>> contributors and users.
>>
>> Specifically the Apex runner addresses:
>>
>> - Have at least 2 contributors interested in maintaining it, and 1
>> committer interested in supporting it: *I'm going to sign up for the
>> support and there are more folks interested. Some have already
>> contributed
>> and helped with PR reviews, others from the Apex community have
>> expressed
>> interest [3].*
>> - Provide both end-user and developer-facing documentation: *Runner
>> has
>> README, capability matrix, Javadoc. Planning to add it to the tutorial
>> later.*
>> - Have at least a basic level of unit test coverage: *Has 30 runner
>> specific tests and passes all Beam RunnableOnService tests.*
>> - Run all existing applicable integration tests with other Beam
>> components and create additional tests as appropriate: * Enabled runner
>> for examples integration tests in the same way as other runners.*
>> - Be able to handle a subset of the model that address a significant
>> set of
>> use cases (aka. ‘traditional batch’ or ‘processing time
>> streaming’): *Passes
>> RunnableOnService without exclusions and example IT.*
>> - Update the capability matrix with the current status: *Done.*
>> - Add a webpage under learn/runners: *Same "TODO" page as other runners
>> added to site.*
>>
>> The PR for the merge:
>> https://github.com/apache/incubator-beam/pull/1305
>>
>> (There are intermittent test failures in individual Travis runs that
>> are
>> unrelated to the runner.)
>>
>> Thanks,
>> Thomas
>>
>> [1]
>> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec6484f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
>>
>> [2]
>> http://beam.apache.org/contribute/contribution-guide/#feature-branches
>>
>> [3]
>> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547
>> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
>> 130691d52@%3Cdev.apex.apache.org%3E
>> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1
Great work Thomas !!
Regards
JB
\u2063\u200b
On Nov 8, 2016, 14:54, at 14:54, Thomas Weise <th...@apache.org> wrote:
>Hi,
>
>As per previous discussion [1], I would like to propose to merge the
>apex-runner branch into master. The runner satisfies the criteria
>outlined
>in [2] and merging it to master will give more visibility to other
>contributors and users.
>
>Specifically the Apex runner addresses:
>
> - Have at least 2 contributors interested in maintaining it, and 1
> committer interested in supporting it: *I'm going to sign up for the
>support and there are more folks interested. Some have already
>contributed
>and helped with PR reviews, others from the Apex community have
>expressed
> interest [3].*
>- Provide both end-user and developer-facing documentation: *Runner
>has
> README, capability matrix, Javadoc. Planning to add it to the tutorial
> later.*
> - Have at least a basic level of unit test coverage: *Has 30 runner
> specific tests and passes all Beam RunnableOnService tests.*
> - Run all existing applicable integration tests with other Beam
>components and create additional tests as appropriate: * Enabled runner
> for examples integration tests in the same way as other runners.*
>- Be able to handle a subset of the model that address a significant
>set of
> use cases (aka. \u2018traditional batch\u2019 or \u2018processing time
>streaming\u2019): *Passes
> RunnableOnService without exclusions and example IT.*
> - Update the capability matrix with the current status: *Done.*
>- Add a webpage under learn/runners: *Same "TODO" page as other runners
> added to site.*
>
>The PR for the merge:
>https://github.com/apache/incubator-beam/pull/1305
>
>(There are intermittent test failures in individual Travis runs that
>are
>unrelated to the runner.)
>
>Thanks,
>Thomas
>
>[1]
>https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec6484f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
>
>[2]
>http://beam.apache.org/contribute/contribution-guide/#feature-branches
>
>[3]
>https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547
><https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
>130691d52@%3Cdev.apex.apache.org%3E
><https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Amit Sela <am...@gmail.com>.
+1 awesome.
Congrats Thomas!
On Tue, Nov 8, 2016 at 3:54 PM Thomas Weise <th...@apache.org> wrote:
> Hi,
>
> As per previous discussion [1], I would like to propose to merge the
> apex-runner branch into master. The runner satisfies the criteria outlined
> in [2] and merging it to master will give more visibility to other
> contributors and users.
>
> Specifically the Apex runner addresses:
>
> - Have at least 2 contributors interested in maintaining it, and 1
> committer interested in supporting it: *I'm going to sign up for the
> support and there are more folks interested. Some have already
> contributed
> and helped with PR reviews, others from the Apex community have
> expressed
> interest [3].*
> - Provide both end-user and developer-facing documentation: *Runner has
> README, capability matrix, Javadoc. Planning to add it to the tutorial
> later.*
> - Have at least a basic level of unit test coverage: *Has 30 runner
> specific tests and passes all Beam RunnableOnService tests.*
> - Run all existing applicable integration tests with other Beam
> components and create additional tests as appropriate: * Enabled runner
> for examples integration tests in the same way as other runners.*
> - Be able to handle a subset of the model that address a significant
> set of
> use cases (aka. ‘traditional batch’ or ‘processing time
> streaming’): *Passes
> RunnableOnService without exclusions and example IT.*
> - Update the capability matrix with the current status: *Done.*
> - Add a webpage under learn/runners: *Same "TODO" page as other runners
> added to site.*
>
> The PR for the merge: https://github.com/apache/incubator-beam/pull/1305
>
> (There are intermittent test failures in individual Travis runs that are
> unrelated to the runner.)
>
> Thanks,
> Thomas
>
> [1]
>
> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec6484f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
>
> [2] http://beam.apache.org/contribute/contribution-guide/#feature-branches
>
> [3]
>
> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547
> <
> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E
> >
> 130691d52@%3Cdev.apex.apache.org%3E
> <
> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E
> >
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Kenneth Knowles <kl...@google.com.INVALID>.
Hi Thomas,
Very good point about establishing more clear definitions of the roles
mentioned in the guidelines. Let's discuss in a separate thread.
Kenn
On Tue, Nov 8, 2016 at 1:03 PM, Thomas Weise <th...@apache.org> wrote:
> Thanks for the support. It may be helpful to describe the roles of
> "maintainer" and "supporter" in this context, perhaps even capture it on:
>
> http://beam.apache.org/contribute/contribution-guide/
>
> Thanks,
> Thomas
>
>
> On Tue, Nov 8, 2016 at 7:51 PM, Robert Bradshaw
> <robertwb@google.com.invalid
> > wrote:
>
> > Nice. I'm +1 modulo one caveat below (hopefully easily addressed).
> >
> > On Tue, Nov 8, 2016 at 5:54 AM, Thomas Weise <th...@apache.org> wrote:
> > > Hi,
> > >
> > > As per previous discussion [1], I would like to propose to merge the
> > > apex-runner branch into master. The runner satisfies the criteria
> > outlined
> > > in [2] and merging it to master will give more visibility to other
> > > contributors and users.
> > >
> > > Specifically the Apex runner addresses:
> > >
> > > - Have at least 2 contributors interested in maintaining it, and 1
> > > committer interested in supporting it: *I'm going to sign up for
> the
> > > support and there are more folks interested. Some have already
> > contributed
> > > and helped with PR reviews, others from the Apex community have
> > expressed
> > > interest [3].*
> >
> > As anyone in the open source ecosystem knows, maintaining is a much
> > higher bar than contributing, but very important. I'd like to see
> > specific names here.
> >
> > > - Provide both end-user and developer-facing documentation: *Runner
> > has
> > > README, capability matrix, Javadoc. Planning to add it to the
> tutorial
> > > later.*
> > > - Have at least a basic level of unit test coverage: *Has 30 runner
> > > specific tests and passes all Beam RunnableOnService tests.*
> > > - Run all existing applicable integration tests with other Beam
> > > components and create additional tests as appropriate: * Enabled
> > runner
> > > for examples integration tests in the same way as other runners.*
> > > - Be able to handle a subset of the model that address a significant
> > set of
> > > use cases (aka. ‘traditional batch’ or ‘processing time
> > > streaming’): *Passes
> > > RunnableOnService without exclusions and example IT.*
> > > - Update the capability matrix with the current status: *Done.*
> > > - Add a webpage under learn/runners: *Same "TODO" page as other
> > runners
> > > added to site.*
> > >
> > > The PR for the merge: https://github.com/apache/
> incubator-beam/pull/1305
> > >
> > > (There are intermittent test failures in individual Travis runs that
> are
> > > unrelated to the runner.)
> > >
> > > Thanks,
> > > Thomas
> > >
> > > [1]
> > > https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648
> > 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> > >
> > > [2] http://beam.apache.org/contribute/contribution-guide/
> > #feature-branches
> > >
> > > [3]
> > > https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547
> > > <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > > 130691d52@%3Cdev.apex.apache.org%3E
> > > <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> > 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> >
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Thomas Weise <th...@apache.org>.
Thanks for the support. It may be helpful to describe the roles of
"maintainer" and "supporter" in this context, perhaps even capture it on:
http://beam.apache.org/contribute/contribution-guide/
Thanks,
Thomas
On Tue, Nov 8, 2016 at 7:51 PM, Robert Bradshaw <robertwb@google.com.invalid
> wrote:
> Nice. I'm +1 modulo one caveat below (hopefully easily addressed).
>
> On Tue, Nov 8, 2016 at 5:54 AM, Thomas Weise <th...@apache.org> wrote:
> > Hi,
> >
> > As per previous discussion [1], I would like to propose to merge the
> > apex-runner branch into master. The runner satisfies the criteria
> outlined
> > in [2] and merging it to master will give more visibility to other
> > contributors and users.
> >
> > Specifically the Apex runner addresses:
> >
> > - Have at least 2 contributors interested in maintaining it, and 1
> > committer interested in supporting it: *I'm going to sign up for the
> > support and there are more folks interested. Some have already
> contributed
> > and helped with PR reviews, others from the Apex community have
> expressed
> > interest [3].*
>
> As anyone in the open source ecosystem knows, maintaining is a much
> higher bar than contributing, but very important. I'd like to see
> specific names here.
>
> > - Provide both end-user and developer-facing documentation: *Runner
> has
> > README, capability matrix, Javadoc. Planning to add it to the tutorial
> > later.*
> > - Have at least a basic level of unit test coverage: *Has 30 runner
> > specific tests and passes all Beam RunnableOnService tests.*
> > - Run all existing applicable integration tests with other Beam
> > components and create additional tests as appropriate: * Enabled
> runner
> > for examples integration tests in the same way as other runners.*
> > - Be able to handle a subset of the model that address a significant
> set of
> > use cases (aka. ‘traditional batch’ or ‘processing time
> > streaming’): *Passes
> > RunnableOnService without exclusions and example IT.*
> > - Update the capability matrix with the current status: *Done.*
> > - Add a webpage under learn/runners: *Same "TODO" page as other
> runners
> > added to site.*
> >
> > The PR for the merge: https://github.com/apache/incubator-beam/pull/1305
> >
> > (There are intermittent test failures in individual Travis runs that are
> > unrelated to the runner.)
> >
> > Thanks,
> > Thomas
> >
> > [1]
> > https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec648
> 4f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
> >
> > [2] http://beam.apache.org/contribute/contribution-guide/
> #feature-branches
> >
> > [3]
> > https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547
> > <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> > 130691d52@%3Cdev.apex.apache.org%3E
> > <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf
> 4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
>
Re: [PROPOSAL] Merge apex-runner to master branch
Posted by Robert Bradshaw <ro...@google.com.INVALID>.
Nice. I'm +1 modulo one caveat below (hopefully easily addressed).
On Tue, Nov 8, 2016 at 5:54 AM, Thomas Weise <th...@apache.org> wrote:
> Hi,
>
> As per previous discussion [1], I would like to propose to merge the
> apex-runner branch into master. The runner satisfies the criteria outlined
> in [2] and merging it to master will give more visibility to other
> contributors and users.
>
> Specifically the Apex runner addresses:
>
> - Have at least 2 contributors interested in maintaining it, and 1
> committer interested in supporting it: *I'm going to sign up for the
> support and there are more folks interested. Some have already contributed
> and helped with PR reviews, others from the Apex community have expressed
> interest [3].*
As anyone in the open source ecosystem knows, maintaining is a much
higher bar than contributing, but very important. I'd like to see
specific names here.
> - Provide both end-user and developer-facing documentation: *Runner has
> README, capability matrix, Javadoc. Planning to add it to the tutorial
> later.*
> - Have at least a basic level of unit test coverage: *Has 30 runner
> specific tests and passes all Beam RunnableOnService tests.*
> - Run all existing applicable integration tests with other Beam
> components and create additional tests as appropriate: * Enabled runner
> for examples integration tests in the same way as other runners.*
> - Be able to handle a subset of the model that address a significant set of
> use cases (aka. ‘traditional batch’ or ‘processing time
> streaming’): *Passes
> RunnableOnService without exclusions and example IT.*
> - Update the capability matrix with the current status: *Done.*
> - Add a webpage under learn/runners: *Same "TODO" page as other runners
> added to site.*
>
> The PR for the merge: https://github.com/apache/incubator-beam/pull/1305
>
> (There are intermittent test failures in individual Travis runs that are
> unrelated to the runner.)
>
> Thanks,
> Thomas
>
> [1]
> https://lists.apache.org/thread.html/2b420a35f05e47561f27c19e8ec6484f595553f32da88fe593ad931d@%3Cdev.beam.apache.org%3E
>
> [2] http://beam.apache.org/contribute/contribution-guide/#feature-branches
>
> [3]
> https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547
> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>
> 130691d52@%3Cdev.apex.apache.org%3E
> <https://lists.apache.org/thread.html/6e7618768cdcde81c28aa9883a1fcf4d3d4e41de4249547130691d52@%3Cdev.apex.apache.org%3E>