You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2018/01/11 19:44:05 UTC

Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/
-----------------------------------------------------------

(Updated Jan. 11, 2018, 7:44 p.m.)


Review request for sentry, Na Li and Sergio Pena.


Changes
-------

Addressed review comments from sergio.


Bugs: SENTRY-2034
    https://issues.apache.org/jira/browse/SENTRY-2034


Repository: sentry


Description
-------

Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.


Diffs (updated)
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a909b913e9d2342a7f76a886d3fdabdb1e309b9f 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java cc0449b1d1d0291049cb1fafebb6d752dd426fbc 


Diff: https://reviews.apache.org/r/63958/diff/4/

Changes: https://reviews.apache.org/r/63958/diff/3-4/


Testing
-------

Made sure that new tests added and all the older tests pass.


Thanks,

kalyan kumar kalvagadda


Re: Review Request 63958: SENTRY-2034: Add e2e tests for testing HMS notification processing.

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63958/#review195470
-----------------------------------------------------------


Ship it!




Ship It!

- Sergio Pena


On Jan. 11, 2018, 7:44 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63958/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2018, 7:44 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2034
>     https://issues.apache.org/jira/browse/SENTRY-2034
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Currently, there are no e2e tests that test the functionality of pulling the notifications from HMS and processing them. Which include updating the update the permissions based on the HMS updates.
> 
> 
> Diffs
> -----
> 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java 21383046f8a5b7386cfe9f6f62c0119542a73382 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingBase.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java 33ace57134b20189aa10bee48f6aae765a1a1830 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java c8eef09ed61e11583838a3dfd3117a9478df23ba 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java a909b913e9d2342a7f76a886d3fdabdb1e309b9f 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java cc0449b1d1d0291049cb1fafebb6d752dd426fbc 
> 
> 
> Diff: https://reviews.apache.org/r/63958/diff/4/
> 
> 
> Testing
> -------
> 
> Made sure that new tests added and all the older tests pass.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>