[GitHub] [ozone] whbing commented on a diff in pull request #4738: HDDS-8653. Let directory inherit parent default ACLs

["whbing (via GitHub)" <gi...@apache.org>]

whbing commented on code in PR #4738:
URL: https://github.com/apache/ozone/pull/4738#discussion_r1253426944


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java:
##########
@@ -236,19 +235,19 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           omMetadataManager.getBucketKey(volumeName, bucketName));
 
       // If FILE_EXISTS we just override like how we used to do for Key Create.
-      List< OzoneAcl > inheritAcls;
       if (LOG.isDebugEnabled()) {
         LOG.debug("BucketName: {}, BucketLayout: {}",
             bucketInfo.getBucketName(), bucketInfo.getBucketLayout());
       }
+
+      OMFileRequest.OMPathInfo pathInfo =

Review Comment:
   > This needs to be done only if its EnableFileSystemPaths for Legacy, otherwise needs to be null.
   
   @sumitagrawl Thanks for the advice！Yes, you are right. But I found that even if `EnableFileSystemPaths` is `false`, the pathInfo can still be fetched before the judgment. Subsequent logic is still compatible. Do you think so?
   I added `TestOMKeyCreateRequest` to verify it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org