You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 22:38:22 UTC
[jira] [Created] (CB-369) Move Authentication out of DroidGap
Move Authentication out of DroidGap
-----------------------------------
Key: CB-369
URL: https://issues.apache.org/jira/browse/CB-369
Project: Apache Callback
Issue Type: Sub-task
Components: Android
Affects Versions: 1.5.0
Reporter: Joe Bowser
Assignee: Joe Bowser
Fix For: 1.7.0
Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-369) Authentication Code doesn't seem to work
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser reassigned CB-369:
-----------------------------
Assignee: Bryce Curtis (was: Joe Bowser)
Can you look at the code that you re-added in DroidGap and the code I put in CordovaWebView and see if we can remove the redundancy somehow?
> Authentication Code doesn't seem to work
> ----------------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Bryce Curtis
> Labels: cordovawebview
> Fix For: 1.8.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CB-369) Authentication Code doesn't seem
to work
Posted by "Bryce Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277047#comment-13277047 ]
Bryce Curtis edited comment on CB-369 at 5/16/12 7:36 PM:
----------------------------------------------------------
I had moved authentication implementation out of CordovaWebView and into CordovaWebViewClient in a previous commit that we went over on Monday, since that's the class that uses it. I added the methods to DroidGap (which are just pass through calls to CordovaWebViewClient) to maintain compatibility with anyone using this feature for 1.7 and before - so there shouldn't be any redundancy.
was (Author: bcurtis):
I had moved authentication implementation out of CordovaWebView and into CordovaWebViewClient in a previous commit, since that's the class that uses it. I added the methods to DroidGap (which are just pass through calls to CordovaWebViewClient) to maintain compatibility with anyone using this feature for 1.7 and before - so there shouldn't be any redundancy.
> Authentication Code doesn't seem to work
> ----------------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Bryce Curtis
> Labels: cordovawebview
> Fix For: 1.8.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-369) Authentication Code doesn't seem to
work
Posted by "Bryce Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277047#comment-13277047 ]
Bryce Curtis commented on CB-369:
---------------------------------
I had moved authentication implementation out of CordovaWebView and into CordovaWebViewClient in a previous commit, since that's the class that uses it. I added the methods to DroidGap (which are just pass through calls to CordovaWebViewClient) to maintain compatibility with anyone using this feature for 1.7 and before - so there shouldn't be any redundancy.
> Authentication Code doesn't seem to work
> ----------------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Bryce Curtis
> Labels: cordovawebview
> Fix For: 1.8.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-369) Move Authentication out of DroidGap
Posted by "Joe Bowser (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser updated CB-369:
--------------------------
Fix Version/s: (was: 1.7.0)
1.8.0
> Move Authentication out of DroidGap
> -----------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Callback
> Issue Type: Sub-task
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Labels: cordovawebview
> Fix For: 1.8.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-369) Authentication Code doesn't seem to work
Posted by "Bryce Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryce Curtis resolved CB-369.
-----------------------------
Resolution: Fixed
Checked in test case - https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=2fbb9c285d52ce9ffd43359fa25e95edad074b13
> Authentication Code doesn't seem to work
> ----------------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Bryce Curtis
> Labels: cordovawebview
> Fix For: 1.8.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-369) Move Authentication out of DroidGap
Posted by "Joe Bowser (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238805#comment-13238805 ]
Joe Bowser commented on CB-369:
-------------------------------
Moved Authentication outside of DroidGap. Needs to be tested somehow!
> Move Authentication out of DroidGap
> -----------------------------------
>
> Key: CB-369
> URL: https://issues.apache.org/jira/browse/CB-369
> Project: Apache Callback
> Issue Type: Sub-task
> Components: Android
> Affects Versions: 1.5.0
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Labels: cordovawebview
> Fix For: 1.7.0
>
>
> Authentication needs to be moved out of DroidGap to another class as part of the move to CordovaWebView
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira