You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "luky116 (via GitHub)" <gi...@apache.org> on 2024/02/03 10:50:45 UTC

Re: [PR] fix:Reclaim the heartbeat response message to avoid memory leakage of GettyRemoting.futures [incubator-seata-go]

luky116 commented on code in PR #648:
URL: https://github.com/apache/incubator-seata-go/pull/648#discussion_r1477045126


##########
pkg/remoting/processor/client/client_heart_beat_processon.go:
##########
@@ -38,5 +38,11 @@ func (f *clientHeartBeatProcessor) Process(ctx context.Context, rpcMessage messa
 			log.Debug("received PONG from {}", ctx)
 		}
 	}
+	msgFuture := getty.GetGettyRemotingInstance().GetMessageFuture(rpcMessage.ID)
+	if msgFuture != nil {
+		// 心跳消息目前没有处理逻辑,所以这里不能notify,否则会导致msgFuture.Done阻塞

Review Comment:
   把中文去了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org